Prevent accidental patroni disk deletion on resize
Summary
During a series of incidents relating to the embedding database on gstg, we accidentally nuked the data disk for the gstg cluster.
It had been manually resized but not updated in terraform. That resulted in plan drift, and applying any plan would then re-create the disk.
We should prevent resource deletion on the generic-stor-with-group module in order to avoid similar mishaps in the future.
Related Incident(s)
Originating issue(s):
Desired Outcome/Acceptance Criteria
Disks do not get accidentally deleted after resizing.
Associated Services
ServicePatroni ServicePatroniCI ServicePatroniRegistry ServicePatroniEmbedding
Corrective Action Issue Checklist
-
Link the incident(s) this corrective action arose out of -
Give context for what problem this corrective action is trying to prevent from re-occurring -
Assign a severity label (this is the highest sev of related incidents, defaults to 'severity::4') -
Assign a priority (this will default to 'Reliability::P4')
Edited by Devin Sylva