<!--Please review https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/ for the most recent information on our change plans and execution policies.--> # Production Change ## Change Summary The request is to add HTTP/2 support to enable gRPC traffic to KAS. Currently, HAProxy treats everything as HTTP/1.1 (no proto directive), which doesn't properly support gRPC. This change is scoped to only non-production environments , but does introduce a couple of no-op changes in Production For transparency :transparency: The only changes that will be touching Production is * [An update to the boilerplate definition to introduce a new field for referencing HTTP protocol used `proto`](https://gitlab.com/gitlab-cookbooks/gitlab-haproxy/-/merge_requests/444/diffs#diff-content-14b92cc0a707f7cb54820cdeb4528ac5b8878a5b) * [An idiomatic fix](https://gitlab.com/gitlab-cookbooks/gitlab-haproxy/-/merge_requests/444/diffs#b1b36a3248391ed9741e018763c273c0b3892d5b_299_298) --- This is related to previous change request work item I created— https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/-/work_items/803 While the linked issue is related to cloudflare, this request is only related to the changes done in the HA proxy config in this MR— https://gitlab.com/gitlab-cookbooks/gitlab-haproxy/-/merge_requests/444#b1b36a3248391ed9741e018763c273c0b3892d5b These changes are related to the issue— https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/-/work_items/803 ## Change Details <!--To automatically add your change to the GitLab Production calendar update the following fields: - Time tracking - Scheduled Date and Time (UTC in format YYYY-MM-DD HH:MM) Bot: https://gitlab.com/gitlab-com/gl-infra/ops-team/toolkit/change-scheduler--> 1. **Services Impacted** - KAS (https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent) 2. **Change Technician** - `@thisisshreya` , `@ashvins` 3. **Change Reviewer** - `@donnaalexandra` 4. **Scheduled Date and Time (UTC in format YYYY-MM-DD HH:MM)** - 2026-03-02 10:30 5. **Time tracking** - 120 6. **Downtime Component** - KAS > [!important] > > If your change involves scheduled maintenance, add a step to set and [unset maintenance mode](https://gitlab.com/gitlab-com/runbooks/-/blob/master/docs/monitoring/set_maintenance_window.md) per our runbooks. This will make sure SLA calculations adjust for the maintenance period. ## Preparation > [!note] > > The following checklists must be done in advance, before setting the label ~&quot;change::scheduled&quot; ### Change Reviewer checklist <!--To be filled out by the reviewer.--> ~C4 ~C3 ~C2 ~C1: - [ ] Check if the following applies: - The **scheduled day and time** of execution of the change is appropriate. - The [change plan](#detailed-steps-for-the-change) is technically accurate. - The change plan includes **estimated timing values** based on previous testing. - The change plan includes a viable [rollback plan](#rollback). - The specified [metrics/monitoring dashboards](#key-metrics-to-observe) provide sufficient visibility for the change. ~C2 ~C1: - [ ] Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details). - The change plan includes success measures for all steps/milestones during the execution. - The change adequately minimizes risk within the environment/service. - The performance implications of executing the change are well-understood and documented. - The specified metrics/monitoring dashboards provide sufficient visibility for the change. - If not, is it possible (or necessary) to make changes to observability platforms for added visibility? - The change has a primary and secondary SRE with knowledge of the details available during the change window. - The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval. - The labels ~&quot;blocks deployments&quot; and/or ~&quot;blocks feature-flags&quot; are applied as necessary. ### Change Technician checklist - [x] The [Change Criticality](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#change-criticalities) has been set appropriately and requirements have been reviewed. - [x] The [change plan](#detailed-steps-for-the-change) is technically accurate. - [x] The [rollback plan](#rollback) is technically accurate and detailed enough to be executed by anyone with access. - [x] This Change Issue is linked to the appropriate Issue and/or Epic - [x] Change has been tested in staging and results noted in a comment on this issue. Click here to see [the comment](https://gitlab.com/gitlab-com/gl-infra/production/-/issues/21287#note_3082026647). - [x] A dry-run has been conducted and results noted in a comment on this issue. - [x] The change execution window respects the [Production Change Lock periods](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#production-change-lock-pcl). - [x] Once all boxes above are checked, mark the change request as scheduled: `/label ~"change::scheduled"` - [x] For ~C1 and ~C2 change issues, the change event is added to the [GitLab Production](https://calendar.google.com/calendar/embed?src=gitlab.com_si2ach70eb1j65cnu040m3alq0%40group.calendar.google.com) calendar by the [change-scheduler bot](https://gitlab.com/gitlab-com/gl-infra/ops-team/toolkit/change-scheduler). It is schedule to run every 2 hours. - [x] For ~C1 and ~C2 change issues, Platform Leadership provides approval with the ~platform_leadership_approved label on the issue. Mention `@gitlab-org/saas-platforms/change-review-leadership` in this issue with a reference to [review guidelines](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/platform-leadership-review/) to get approval and provide visibility to all infrastructure managers. - [x] For ~C1, ~C2, or ~&quot;blocks deployments&quot; change issues, confirm with Release managers that the change does not overlap or hinder any release process (In `#production` channel, mention `@release-managers` and this issue and await their acknowledgment.) - [ ] For ~C1 change issues or ~C2 change issues happening during weekend, SREs on-call must be informed [at least 2 weeks in advance](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#approval). Check [the incident.io GitLab.com Production EOC schedule](https://app.incident.io/gitlab/on-call/schedules/01K5YWAGZ7YCQGAG7ATQ9XQWHW) to find who will be on-call at the scheduled day and time. ## Detailed steps for the change ### Pre-execution steps > [!note] > > The following steps should be done right at the scheduled time of the change request. The [preparation steps](#preparation) are listed below. - [ ] Make sure all tasks in [Change Technician checklist](#change-technician-checklist) are done - [ ] For ~C1 and ~C2 change issues, the SRE on-call has been informed prior to change being rolled out. - [ ] The SRE on-call provided approval with the ~eoc_approved label on the issue. - [ ] For ~C1, ~C2, or ~&quot;blocks deployments&quot; change issues, Release managers have been informed prior to change being rolled out. (In `#production` channel, mention `@release-managers` and this issue and await their acknowledgment.) - [ ] There are currently no [active incidents](https://gitlab.com/gitlab-com/gl-infra/production/-/issues/?sort=created_date&state=opened&label_name%5B%5D=Incident%3A%3AActive&or%5Blabel_name%5D%5B%5D=severity%3A%3A1&or%5Blabel_name%5D%5B%5D=severity%3A%3A2&first_page_size=20) that are ~severity::1 or ~severity::2 - [ ] If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change. - [ ] Merge the MR https://gitlab.com/gitlab-cookbooks/gitlab-haproxy/-/merge_requests/444 a few hours before execution ### Change steps - steps to take to execute the change _Estimated Time to Complete (mins)_ - 120 - [x] Set label ~&quot;change::in-progress&quot; `/label ~change::in-progress` - [x] Merge the MR created to bump the HAProxy version in [chef-repo](https://gitlab.com/gitlab-com/gl-infra/chef-repo) , there will be one for staging and one for production, merge them both - [x] Run chef-client manually ``` knife ssh -C1 'name:haproxy-main* AND chef_environment:gstg' 'sudo chef-client' ``` - [x] Confirm that HAProxy is able to route traffic correctly based on the protocol To test the changes all we have to check is that HA Proxy is correctly propagating the protocol the client is using. ```shell $ echo "=== Testing HTTP/2 gRPC Routing ===" && \ curl -k -s -v --http2 https://kas.staging.gitlab.com/liveness 2>&1 | grep -E "(ALPN, server accepted|> GET|< HTTP/2)" && \ echo "" && \ echo "=== Testing HTTP/1.1 WebSocket Routing ===" && \ curl -k -s -v --http1.1 https://kas.staging.gitlab.com/liveness 2>&1 | grep -E "(ALPN, server accepted|> GET|< HTTP/1)" ``` Should give this output if everything works expectedly↵ ```shell === Testing HTTP/2 gRPC Routing === * ALPN, server accepted to use h2 > GET /liveness HTTP/2 < HTTP/2 200 === Testing HTTP/1.1 WebSocket Routing === * ALPN, server accepted to use http/1.1 > GET /liveness HTTP/1.1 < HTTP/1.1 200 OK ``` - [x] Check if we see an increase in errors for the [kas backend](https://dashboards.gitlab.net/goto/dfdpr9u7dkhs0d?orgId=1) - [x] Set label ~&quot;change::complete&quot; `/label ~change::complete` ## Rollback ### Rollback steps - steps to be taken in the event of a need to rollback this change _Estimated Time to Complete (mins)_ - {+Estimated Time to Complete in Minutes+} - [ ] Revert the version MR bump - [ ] Run chef-client manually ``` knife ssh -C1 'name:haproxy-* AND chef_environment:gstg' 'sudo chef-client' ``` - [ ] Set label ~&quot;change::aborted&quot; `/label ~change::aborted` ## Monitoring ### Key metrics to observe <!--* Describe which dashboards and which specific metrics we should be monitoring related to this change using the format below.--> - Metric: HAProxy Grafana Dashboard - Location: [https://dashboards.gitlab.net/goto/efe3uyibdz5kwa?orgId=1](https://dashboards.gitlab.net/goto/efe3uyibdz5kwa?orgId=1%E2%86%B5) - What changes to this metric should prompt a rollback: if requests are unable to reach the correct backend , or we see an increase in errors