2023-04-28: Update rlease.gitaly.net gitaly configuration
Production Change
Change Summary
In https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/19359 we are updating Gitaly configuration to follow the new structure
Change Details
- Services Impacted - http://release.gitlab.net/
-
Change Technician -
@steveazz
- Change Reviewer - @fshabir
- Time tracking - unknown
- Downtime Component - none
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 15
-
Set label changein-progress /label ~change::in-progress
-
Disable chef client ssh release-01-sv-release.c.gitlab-release.internal -- sudo chef-client-disable "change request: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/9619"
-
Update secret in vault with glsh vault edit-secret chef env/release/shared/gitlab-omnibus-secrets
-
gitaly.auth_token
goes togitaly.configuration.auth.token
-
-
Merge https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/3342 -
Enable and run chef-client ssh release-01-sv-release.c.gitlab-release.internal -- sudo chef-client-enable ssh release-01-sv-release.c.gitlab-release.internal -- sudo chef-client
-
Make sure gitaly is running ssh release-01-sv-release.c.gitlab-release.internal -- sudo gitlab-ctl status gitaly
-
Check we have no deprecation warnings ssh release-01-sv-release.c.gitlab-release.internal -- sudo gitlab-ctl reconfigure ssh release-01-sv-release.c.gitlab-release.internal -- "sudo find /var/log/gitlab/reconfigure -type f -printf '%T@ %p\n' | sort -k1,1nr | head -1 | awk '{print $2}' | xargs cat"
-
Validate that there is no diff in the configuration ssh release-01-sv-release.c.gitlab-release.internal -- "sudo find /opt/gitlab/embedded/cookbooks/cache/backup/var/opt/gitlab/gitaly/ -type f -name 'config.toml*' -printf '%T@ %p\n' | sort -k1,1nr | head -1 | awk '{print \$2}' | xargs -I{} sudo diff /var/opt/gitlab/gitaly/config.toml {} "
-
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - 15
-
Disable chef client ssh gitlab-01-inf-ops.c.gitlab-ops.internal -- sudo chef-client-disable "change request: https://gitlab.com/gitlab-com/gl-infra/production/-/issues/9619"
-
Update secret in vault with glsh vault edit-secret
-
gitaly.auth.token
goes togitaly.auth_token
-
-
Revert https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/3341 -
Enable and run chef-client ssh release-01-sv-release.c.gitlab-release.internal -- sudo chef-client-enable ssh release-01-sv-release.c.gitlab-release.internal -- sudo chef-client
-
Make sure gitaly is running ssh release-01-sv-release.c.gitlab-release.internal -- sudo gitlab-ctl status gitaly
-
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: Metric Name
- Location: Dashboard URL
- What changes to this metric should prompt a rollback: Describe Changes
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.