[gprd] Disable `security_policy_global_group_approvers_enabled` application setting
Production Change
Change Summary
gitlab-org/gitlab!110653 (merged) introduced the security_policy_global_group_approvers_enabled
application setting. The setting controls the database query the security policy editor's group selection dropdown is populated with.
The setting is enabled by default and we need to disable it on production.
The database query for the disabled setting is more performant than its counterpart.
Related to gitlab-org/gitlab#378234 (closed)
Change Details
- Services Impacted - Rails monolith, Sidekiq, Postgres
- Change Technician - @ahmadsherif, @bauerdominic
- Change Reviewer - @rehab
- Time tracking - 20 minutes
- Downtime Component - none
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 140
-
Set label changein-progress /label ~change::in-progress
-
Disable the application setting in gprd curl -sIXPUT --header "PRIVATE-TOKEN: glpat-123" "https://gitlab.com/api/v4/application/settings?security_policy_global_group_approvers_enabled=false"
-
Observe metrics for 2 hours, see Verifying metrics after enabling feature flag -
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - 10
-
Enable the application setting curl -sIXPUT --header "PRIVATE-TOKEN: glpat-123" "https://gitlab.com/api/v4/application/settings?security_policy_global_group_approvers_enabled=true"
-
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: Database Time for
Security::ProcessScanResultPolicyWorker
/other relevant metrics relevant to worker- Location: Grafana dashboard
- What changes to this metric should prompt a rollback: elevated resource consumption
- Metric:
Projects::Security::PoliciesController
metrics- Location: Grafana dashboard
- What changes to this metric should prompt a rollback: elevated resource consumption
- Metric:
Groups::Security::PoliciesController
metrics- Location: Grafana dashboard
- What changes to this metric should prompt a rollback: elevated resource consumption
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Ahmad Sherif