2023-02-24: Enable new Rack::Attack backend

Production Change

Change Summary

Set GITLAB_RACK_ATTACK_NEW_STORE=1 for webservice and sidekiq processes. This enables the new rate limiting backend introduced by gitlab-org/gitlab!112593 (merged).

Change Details

  1. Services Impacted - ServiceWeb ServiceAPI ServiceSidekiq ServiceRedis
  2. Change Technician - @jacobvosmaer-gitlab
  3. Change Reviewer - @igorwwwwwwwwwwwwwwwwwwww
  4. Time tracking - 40
  5. Downtime Component - No

Detailed steps for the change

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 30

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - 10

Monitoring

Key metrics to observe

  • Metric: HTTP 429 rate for API service
    • Location: thanos
    • What changes to this metric should prompt a rollback: Should not change
  • Metric: Redis-ratelimiting request rate
    • Location: grafana
    • What changes to this metric should prompt a rollback: Should not increase
  • Metric: Redis-ratelimiting CPU utilization
    • Location: grafana
    • What changes to this metric should prompt a rollback: Should not increase

Change Reviewer checklist

C4 C3 C2 C1:

  • Check if the following applies:
    • The scheduled day and time of execution of the change is appropriate.
    • The change plan is technically accurate.
    • The change plan includes estimated timing values based on previous testing.
    • The change plan includes a viable rollback plan.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • Check if the following applies:
    • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
    • The change plan includes success measures for all steps/milestones during the execution.
    • The change adequately minimizes risk within the environment/service.
    • The performance implications of executing the change are well-understood and documented.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
      • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
    • The change has a primary and secondary SRE with knowledge of the details available during the change window.
    • The labels blocks deployments and/or blocks feature-flags are applied as necessary

Change Technician checklist

  • Check if all items below are complete:
    • The change plan is technically accurate.
    • This Change Issue is linked to the appropriate Issue and/or Epic
    • Change has been tested in staging and results noted in a comment on this issue.
    • A dry-run has been conducted and results noted in a comment on this issue.
    • The change execution window respects the Production Change Lock periods.
    • For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
    • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
    • For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
    • For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
    • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
    • There are currently no active incidents that are severity1 or severity2
    • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Jacob Vosmaer