CR - GPRD - Enable glpat_autorevocation feature flag for GitLab team members and Beta customer

Production Change

Change Summary

As part of gitlab-org/gitlab#382610 (closed) we will be rolling out a user-level feature flag across GitLab team members and select beta customers. This is primarily intended to quickly allow opt-ins from various team members in advance of general availability.

The flag is already enabled for groupstatic analysis team members and as other teams opt-in will be required to mass-enable.

Below script relies off definitive list of teams that have opted-in: https://gitlab.com/-/snippets/2467743

Change Details

  1. Services Impacted - ServiceAPI
  2. Change Technician - @ahanselka
  3. Change Reviewer - @rehab
  4. Time tracking - 5 minutes
  5. Downtime Component - None

Detailed steps for the change

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 5 minutes

  • Set label changein-progress /label ~change::in-progress
  • Open rails console with write access in production
  • Execute the following script
SNIPPET_URL = "https://gitlab.com/-/snippets/2467743/raw/main/groups_with_direct_members.json"
FEATURE_FLAG = :gitlab_pat_auto_revocation

response = Gitlab::HTTP.get(SNIPPET_URL)
ids = JSON.parse(response.body)

puts "Loaded #{ids.size} group IDs"

before_count = Feature::FlipperGate.where(feature_key: FEATURE_FLAG.to_s).count

ids.values.each do |id|
  group = Group.find_by_id(id)
  unless group
    puts "WARNING: #{id} not found!"
    next
  end

  User.where(id: group.direct_members.select(:user_id)).find_each do |user|
    Feature.enable(FEATURE_FLAG, user)
  end
end

after_count = Feature::FlipperGate.where(feature_key: FEATURE_FLAG.to_s).count
diff_count = after_count - before_count

if diff_count == ids.size
  puts "enabled for #{diff_count} members"
else
  puts "WARNING: Expected feature flag to be enabled for #{ids.size} members, but only did for #{diff_count}"
end
  • Report any WARNING message to the engineer requesting the change and wait for confirmation
  • Set label changecomplete /label ~change::complete

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes

  • Execute the following snippet to re-enable the feature flag for all target groups:

    before_count = Feature::FlipperGate.where(feature_key: FEATURE_FLAG.to_s).count

ids.values.each do |id|
  group = Group.find_by_id(id)
  group && User.where(id: group.direct_members.select(:user_id)).find_each do |user|
    Feature.disable(FEATURE_FLAG, user)
  end
end

Monitoring

Key metrics to observe

Change Reviewer checklist

C4 C3 C2 C1:

  • Check if the following applies:
    • The scheduled day and time of execution of the change is appropriate.
    • The change plan is technically accurate.
    • The change plan includes estimated timing values based on previous testing.
    • The change plan includes a viable rollback plan.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • Check if the following applies:
    • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
    • The change plan includes success measures for all steps/milestones during the execution.
    • The change adequately minimizes risk within the environment/service.
    • The performance implications of executing the change are well-understood and documented.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
      • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
    • The change has a primary and secondary SRE with knowledge of the details available during the change window.
    • The labels blocks deployments and/or blocks feature-flags are applied as necessary

Change Technician checklist

  • Check if all items below are complete:
    • The change plan is technically accurate.
    • This Change Issue is linked to the appropriate Issue and/or Epic
    • Change has been tested in staging and results noted in a comment on this issue.
    • A dry-run has been conducted and results noted in a comment on this issue.
    • The change execution window respects the Production Change Lock periods.
    • For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
    • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
    • For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
    • For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
    • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
    • There are currently no active incidents that are severity1 or severity2
    • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Alex Hanselka