Skip to content

Removal of sigin-Page text for staging and .com

Production Change

Change Summary

Hi Folks, As part of the beautifying our UI Initiative I teamed up with @emilybauman to work on restyling of our Login Page (related Epic: gitlab-org&8557 (closed))

This feature is currently implemented behind the restyle_login_page which is already enabled for staging. And we're very excited to enable this for prod on 2022/09/07 08:00 UTC if everything works out as planned 🤞

Why does this matter for infra? The current implementation of the sign-page is using sign-in page messages as part of the layout.

The new redesigned version still supports this feature but is not planning for the GitLab instance on .com to work with sign-in page messages. Enabling the flag with the current sign-in page messages, does not break anything. But it doesn't match the designs we're wishing for and also contains duplications of information.

Here's what we need help with:

  • remove the text for sign-in page message for https://staging.gitlab.com/ (can be done anytime)
  • remove the text for sign-in page message for https://gitlab.com/ (this needs to be done in sync with the enabling of the flag, we're hoping to enable the flag on 2022/09/07 08:00 UTC will keep you posted)

This is a major change, why don't you roll this out using an experiment?

The dependency of the current implementation on the sign-in page message is holding us back from rolling this out via an experiment. The sign-in page message is quite binary it's either defined or undefined. If we'd be running an experiment one of the 2 versions would have to live with a missing sign-in page message or duplicated content.

How do we know if everything is allright?

We're having a good test-coverage for this and are doing manual testing on staging.gitlab.com. Once the flag is enabled for .com we'll be monitoring this dashboard for successful logins.

Provide a high-level summary of the change and its purpose.

Change Details

  1. Services Impacted - List services
  2. Change Technician - DRI for the execution of this change
  3. Change Reviewer - DRI for the review of this change
  4. Time tracking - Time, in minutes, needed to execute all change steps, including rollback
  5. Downtime Component - If there is a need for downtime, include downtime estimate here

Detailed steps for the change

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

  1. Rollback restyle_login_page page using chatops
  2. Reintroduce .com signin-page text

Estimated Time to Complete (3) - Estimated Time to Complete in Minutes

  • Rollback Step 1
  • Rollback Step 2
  • Set label changeaborted /label ~change::aborted

Monitoring

Key metrics to observe

Successful logins: dashboard

  • Metric: Metric Name
    • Location: Dashboard URL
    • What changes to this metric should prompt a rollback: Describe Changes

Change Reviewer checklist

C4 C3 C2 C1:

  • Check if the following applies:
    • The scheduled day and time of execution of the change is appropriate.
    • The change plan is technically accurate.
    • The change plan includes estimated timing values based on previous testing.
    • The change plan includes a viable rollback plan.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • Check if the following applies:
    • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
    • The change plan includes success measures for all steps/milestones during the execution.
    • The change adequately minimizes risk within the environment/service.
    • The performance implications of executing the change are well-understood and documented.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
      • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
    • The change has a primary and secondary SRE with knowledge of the details available during the change window.
    • The labels blocks deployments and/or blocks feature-flags are applied as necessary

Change Technician checklist

  • Check if all items below are complete:
    • The change plan is technically accurate.
    • This Change Issue is linked to the appropriate Issue and/or Epic
    • Change has been tested in staging and results noted in a comment on this issue.
    • A dry-run has been conducted and results noted in a comment on this issue.
    • The change execution window respects the Production Change Lock periods.
    • For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
    • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
    • For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
    • For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
    • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
    • There are currently no active incidents that are severity1 or severity2
    • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.