2022-08-23: Merge gitaly chef run_list for main stage

Production Change

Change Summary

Merge gprd-base-stor-gitaly-main into gprd-base-stor-gitaly.

Before:

graph TD
    gprd-base-stor-gitaly-common-->gprd-base-stor-gitaly
    gprd-base-stor-gitaly-common-->gprd-base-stor-gitaly-cny

    gprd-base-stor-gitaly-main-->|mergeable|gprd-base-stor-gitaly

    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-hdd
    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-marquee
    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-praefect

After:

graph TD
    gprd-base-stor-gitaly-common-->gprd-base-stor-gitaly
    gprd-base-stor-gitaly-common-->gprd-base-stor-gitaly-cny

    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-hdd
    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-marquee
    gprd-base-stor-gitaly-->gprd-base-stor-gitaly-praefect

Reference: https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/16204

Change Details

1. Services Impacted - ServiceGitaly
2. Change Technician - @steveazz
3. Change Reviewer - @knottos
4. Time tracking - 20 minutes
5. Downtime Component - none

Detailed steps for the change

Change Steps - 15

Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes

• Set label changein-progress /label ~change::in-progress
• knife ssh -C30 roles:gprd-base-stor-gitaly sudo chef-client-disable
• Check that chef-client is disabled (thanos)
• Merge https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/2230
• Process file-01-stor-gprd.c.gitlab-production.internal
  • sudo cp /var/opt/gitlab/gitaly/config.toml /var/opt/gitlab/gitaly/config.toml.bak
  • sudo chef-client-enable
  • sudo chef-client
  • sudo diff -u /var/opt/gitlab/gitaly/config.toml.bak /var/opt/gitlab/gitaly/config.toml: We expect no diff
  • sudo rm /var/opt/gitlab/gitaly/config.toml.bak
• Process file-cny-01-stor-gprd.c.gitlab-production.internal
  • sudo cp /var/opt/gitlab/gitaly/config.toml /var/opt/gitlab/gitaly/config.toml.bak
  • sudo chef-client-enable
  • sudo chef-client
  • sudo diff -u /var/opt/gitlab/gitaly/config.toml.bak /var/opt/gitlab/gitaly/config.toml: We expect no diff
  • sudo rm /var/opt/gitlab/gitaly/config.toml.bak
• Process file-hdd-01-stor-gprd.c.gitlab-production.internal
  • sudo cp /var/opt/gitlab/gitaly/config.toml /var/opt/gitlab/gitaly/config.toml.bak
  • sudo chef-client-enable
  • sudo chef-client
  • sudo diff -u /var/opt/gitlab/gitaly/config.toml.bak /var/opt/gitlab/gitaly/config.toml: We expect no diff
  • sudo rm /var/opt/gitlab/gitaly/config.toml.bak
• Process file-marquee-01-stor-gprd.c.gitlab-production.internal
  • sudo cp /var/opt/gitlab/gitaly/config.toml /var/opt/gitlab/gitaly/config.toml.bak
  • sudo chef-client-enable
  • sudo chef-client
  • sudo diff -u /var/opt/gitlab/gitaly/config.toml.bak /var/opt/gitlab/gitaly/config.toml: We expect no diff
  • sudo rm /var/opt/gitlab/gitaly/config.toml.bak
• Process file-praefect-01-stor-gprd.c.gitlab-production.internal
  • sudo cp /var/opt/gitlab/gitaly/config.toml /var/opt/gitlab/gitaly/config.toml.bak
  • sudo chef-client-enable
  • sudo chef-client
  • sudo diff -u /var/opt/gitlab/gitaly/config.toml.bak /var/opt/gitlab/gitaly/config.toml: We expect no diff
  • sudo rm /var/opt/gitlab/gitaly/config.toml.bak
• knife ssh -C30 roles:gprd-base-stor-gitaly sudo chef-client-enable
• Check that chef-client is enabled (thanos)
• Set label changecomplete /label ~change::complete

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - 10

• Revert https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/2230
• knife ssh -C30 roles:gprd-base-stor-gitaly sudo chef-client-enable
• Check that chef-client is enabled (thanos)
• Set label changeaborted /label ~change::aborted

Change Reviewer checklist

C4 C3 C2 C1:

• Check if the following applies:
  • The scheduled day and time of execution of the change is appropriate.
  • The change plan is technically accurate.
  • The change plan includes estimated timing values based on previous testing.
  • The change plan includes a viable rollback plan.
  • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

• Check if the following applies:
  • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
  • The change plan includes success measures for all steps/milestones during the execution.
  • The change adequately minimizes risk within the environment/service.
  • The performance implications of executing the change are well-understood and documented.
  • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
    • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
  • The change has a primary and secondary SRE with knowledge of the details available during the change window.
  • The labels blocks deployments and/or blocks feature-flags are applied as necessary

Change Technician checklist

• Check if all items below are complete:
  • The change plan is technically accurate.
  • This Change Issue is linked to the appropriate Issue and/or Epic
  • Change has been tested in staging and results noted in a comment on this issue.
  • A dry-run has been conducted and results noted in a comment on this issue.
  • The change execution window respects the Production Change Lock periods.
  • For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
  • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
  • For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
  • For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
  • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
  • There are currently no active incidents that are severity1 or severity2
  • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.