2022-07-12: Merge cny and main pages into 1
Production Change
Change Summary
When an alert for a service fires, and both the main
and cny
stage fire in 1 alert, the SRE on-call gets paged twice. For example
Change Details
- Services Impacted - ServiceAlertManager
-
Change Technician -
@steveazz
- Change Reviewer - @mwasilewski-gitlab
- Time tracking - 10 minutes
- Downtime Component - none
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 10
-
Set label changein-progress /label ~change::in-progress
-
Wait for gitlab-com/runbooks!4807 (merged) to be deployed -
Verify that the configuration was updated in https://alerts.gitlab.net/#/status as shown in after section -
Create fake alerts that will page the on-call kubectl -n monitoring exec -it alertmanager-gitlab-monitoring-promethe-alertmanager-0 -- sh amtool alert add "RegistryServiceGarbagecollectorErrorSLOViolation" \ env=gprd \ environment=gprd \ type=registry \ component=GarbageCollection \ feature_category=not_owned \ tier=sv \ stage=main \ severity=page \ user_impacting=yes \ pager=pagerduty \ monitor=global \ rules_domain=general \ slo_alert=yes \ alert_type=symptom \ alert_class=slo_violation \ sli_type=apdex \ --annotation=title="Title for ${alert}" \ --annotation=description="Testing https://gitlab.com/gitlab-com/gl-infra/production/-/issues/7414" \ --annotation=promql_template_1='sum by (env,environment,tier,stage,region) ( rate(registry_gc_runs_total{environment=\"gprd\",error=\"true\",region=\"us-east1\",stage=\"cny\",type=\"registry\"}[5m]))' \ --annotation=promql_template_2='sum by (env,environment,tier,stage,region) ( rate(registry_gc_runs_total{environment=\"gprd\",error=\"true\",region=\"us-east1\",stage=\"cny\",type=\"registry\"}[5m]))' \ --alertmanager.url "http://127.0.0.1:9093" amtool alert add "RegistryServiceGarbagecollectorErrorSLOViolation" \ env=gprd \ environment=gprd \ type=registry \ component=GarbageCollection \ feature_category=not_owned \ tier=sv \ stage=cny \ severity=page \ user_impacting=yes \ pager=pagerduty \ monitor=global \ rules_domain=general \ slo_alert=yes \ alert_type=symptom \ alert_class=slo_violation \ sli_type=apdex \ --annotation=title="Title for ${alert}" \ --annotation=description="Testing https://gitlab.com/gitlab-com/gl-infra/production/-/issues/7414" \ --annotation=promql_template_1='sum by (env,environment,tier,stage,region) ( rate(registry_gc_runs_total{environment=\"gprd\",error=\"true\",region=\"us-east1\",stage=\"cny\",type=\"registry\"}[5m]))' \ --annotation=promql_template_2='sum by (env,environment,tier,stage,region) ( rate(registry_gc_runs_total{environment=\"gprd\",error=\"true\",region=\"us-east1\",stage=\"cny\",type=\"registry\"}[5m]))' \ --alertmanager.url "http://127.0.0.1:9093"
-
Verify that the on-call got paged only once by the GitLab Produciton service, instead of SLO Alerts gprd main stage and SLO alerts gprd cny stage -
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes
-
Open revert merge request for gitlab-com/runbooks!4807 (merged) -
Wait for it to get deployed -
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: Metric Name
- Location: Dashboard URL
- What changes to this metric should prompt a rollback: Describe Changes
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.