Restore "expected" remote URL on private and shared-gitlab-org runners

Production Change

Change Summary

Finalization of https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/14874 - step 1/2.

While working on a Rapid Action to reduce networking cost caused by CI Runners we've been left with one last step: migrate shared runners to use the internal load balance for Runner API and Git communication. That migration was blocked by an edge case that we've found is causing problems in some number of customer jobs.

We've found a solution for this problem and are going to deploy it now.

This change will reconfigure shared-gitlab-org and private (workers targeting GitLab.com) runners. This change is not necessary here, but it will not hurt us and will bring consistency across all configurations.

The change was tested on runners for staging.gitlab.com - it's present there since few weeks and we didn't see it causing any problems. If we will not see any problems on shared-gitlab-org and private runners within a day, we will proceed with another change that will reconfigure the shared runners.

Change Details

  1. Services Impacted - ServiceCI Runners
  2. Change Technician - @tmaczukin
  3. Change Reviewer - @jarv
  4. Time tracking - 60
  5. Downtime Component - no downtime expected

Detailed steps for the change

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 30

NO BLUE/GREEN SWITCH IS NEEDED IN THIS CASE!

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - 30

NO BLUE/GREEN SWITCH IS NEEDED IN THIS CASE!

Monitoring

Key metrics to observe

Change Reviewer checklist

C4 C3 C2 C1:

  • Check if the following applies:
    • The scheduled day and time of execution of the change is appropriate.
    • The change plan is technically accurate.
    • The change plan includes estimated timing values based on previous testing.
    • The change plan includes a viable rollback plan.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • Check if the following applies:
    • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
    • The change plan includes success measures for all steps/milestones during the execution.
    • The change adequately minimizes risk within the environment/service.
    • The performance implications of executing the change are well-understood and documented.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
      • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
    • The change has a primary and secondary SRE with knowledge of the details available during the change window.
    • The labels blocks deployments and/or blocks feature-flags are applied as necessary

Change Technician checklist

  • Check if all items below are complete:
    • The change plan is technically accurate.
    • This Change Issue is linked to the appropriate Issue and/or Epic
    • Change has been tested in staging and results noted in a comment on this issue.
    • A dry-run has been conducted and results noted in a comment on this issue.
    • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
    • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
    • There are currently no active incidents that are severity1 or severity2
    • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Tomasz Maczukin