2022-03-18: Post Deploy migrations Failure on Auto-Deploy
Incident DRI
Current Status
A database migration which requires an exclusive lock on two tables is unable to complete. This is blocking auto-deploy from completing.
Summary for CMOC notice / Exec summary:
- Customer Impact: none
- Service Impact: deploys blocked
- Impact Duration: 18:36 - 20:13 (87 minutes)
- Root cause: gitlab-org/gitlab!83129 (merged)
Timeline
Recent Events (available internally only):
- Deployments
- Feature Flag Changes
- Infrastructure Configurations
- GCP Events (e.g. host failure)
- Gitlab.com Latest Updates
All times UTC.
2022-03-18
-
18:36
- @skarbek declares incident in Slack. -
20:13
- change #6645 (closed) executed in production.
Create related issues
Use the following links to create related issues to this incident if additional work needs to be completed after it is resolved:
- Support contact request
- Corrective action
- Investigation followup
- Confidential issue
- QA investigation
- Infradev
Takeaways
- Because of this failure, we cut the 14.9 RC from an earlier deployment
- There are now concerns raised regarding the capability to run this same migration for self managed users, especially those that utilize zero downtime upgrades - https://gitlab.com/gitlab-org/gitlab/-/issues/356153#note_880562921
- The actual intent of the migration HAS NOT yet been executed against the production database for GitLab.com, this is currently slated for CR: #6646 (closed)
- We lacked DBRE coverage, and thus relied on GitLab Database Maintainers and other SRE's whom have specialized knowledge of Postgres to assist us during our Change Request to complete mitigation
Corrective Actions
Corrective actions should be put here as soon as an incident is mitigated, ensure that all corrective actions mentioned in the notes below are included.
- ...
Note: In some cases we need to redact information from public view. We only do this in a limited number of documented cases. This might include the summary, timeline or any other bits of information, laid out in out handbook page. Any of this confidential data will be in a linked issue, only visible internally. By default, all information we can share, will be public, in accordance to our transparency value.
Incident Review
-
Ensure that the exec summary is completed at the top of the incident issue, the timeline is updated and relevant graphs are included in the summary -
If there are any corrective action items mentioned in the notes on the incident, ensure they are listed in the "Corrective Action" section -
Fill out relevant sections below or link to the meeting review notes that cover these topics
Customer Impact
-
Who was impacted by this incident? (i.e. external customers, internal customers)
- internal customers, specifically teamDelivery for AutoDeploy
-
What was the customer experience during the incident? (i.e. preventing them from doing X, incorrect display of Y, ...)
- n/a
-
How many customers were affected?
- n/a
-
If a precise customer impact number is unknown, what is the estimated impact (number and ratio of failed requests, amount of traffic drop, ...)?
- n/a
What were the root causes?
Incident Response Analysis
-
How was the incident detected?
- Failed deployment job
-
How could detection time be improved?
- No
-
How was the root cause diagnosed?
- Details from the output of the failed deployment job
-
How could time to diagnosis be improved?
- No
-
How did we reach the point where we knew how to mitigate the impact?
- We followed standard procedure for looking at the code contained in the package that contained a database migration.
-
How could time to mitigation be improved?
- .No
-
What went well?
- n/a
Post Incident Analysis
-
Did we have other events in the past with the same root cause?
- Yes
-
Do we have existing backlog items that would've prevented or greatly reduced the impact of this incident?
- No
- Was this incident triggered by a change (deployment of code or change to infrastructure)? If yes, link the issue.
What went well?
- ...
Guidelines
Resources
- If the Situation Zoom room was utilised, recording will be automatically uploaded to Incident room Google Drive folder (private)