Skip to content

2022-02-28: Start disabling flaky webhooks

Production Change

Change Summary

Enable web_hooks_disable_failed feature flag globally.

This requires awareness and monitoring since it could cause issues with webhooks being disabled, either temporarily or permanently for our users. Support should know what how to advise users.

Docs were added in gitlab-org/gitlab!81842 (merged)

Change Details

  1. Services Impacted - ServiceWeb ServiceSidekiq
  2. Change Technician - @alexkalderimis
  3. Change Reviewer - @igorwwwwwwwwwwwwwwwwwwww
  4. Time tracking - unknown
  5. Downtime Component - none

Detailed steps for the change

Pre-Change Steps - steps to be completed before execution of the change

Estimated Time to Complete (0 mins) - Estimated Time to Complete in Minutes

Change Steps - steps to take to execute the change

Estimated Time to Complete (1 mins) - Estimated Time to Complete in Minutes

  • Set the web_hooks_disable_failed feature flag to true globally

Post-Change Steps - steps to take to verify the change

None

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (1 mins) - Estimated Time to Complete in Minutes

  • /chatops run feature set web_hooks_disable_failed false

Monitoring

Key metrics to observe

Summary of infrastructure changes

  • Does this change introduce new compute instances?: NO
  • Does this change re-size any existing compute instances? NO
  • Does this change introduce any additional usage of tooling like Elastic Search, CDNs, Cloudflare, etc? NO

Change Reviewer checklist

C4 C3 C2 C1:

  • The scheduled day and time of execution of the change is appropriate.
  • The change plan is technically accurate.
  • The change plan includes estimated timing values based on previous testing.
  • The change plan includes a viable rollback plan.
  • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
  • The change plan includes success measures for all steps/milestones during the execution.
  • The change adequately minimizes risk within the environment/service.
  • The performance implications of executing the change are well-understood and documented.
  • The specified metrics/monitoring dashboards provide sufficient visibility for the change. - If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
  • The change has a primary and secondary SRE with knowledge of the details available during the change window.

Change Technician checklist

  • This issue has a criticality label (e.g. C1, C2, C3, C4) and a change-type label (e.g. changeunscheduled, changescheduled) based on the Change Management Criticalities.
  • This issue has the change technician as the assignee.
  • Pre-Change, Change, Post-Change, and Rollback steps and have been filled out and reviewed.
  • This Change Issue is linked to the appropriate Issue and/or Epic
  • Necessary approvals have been completed based on the Change Management Workflow.
  • Change has been tested in staging and results noted in a comment on this issue.
  • A dry-run has been conducted and results noted in a comment on this issue.
  • SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
  • Release managers have been informed (If needed! Cases include DB change) prior to change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
  • There are currently no active incidents.
Edited by Alex Kalderimis