Change the Diff Limits in Admin settings on gitlab.com
Production Change
Change Summary
Currently the use of the application setting is behind a feature flag, and is not currently being used on Gitlab.com. I would like to turn this feature flag on, but the default diff limits are different to the current ones.
This change is to change the admin setting diff limits to match the diff limits that Gitlab.com currently uses before turning on the feature flag.
Change Details
- Services Impacted - N/A
- Change Technician - @marin
- Change Reviewer - @marin
- Time tracking - 8
- Downtime Component - N/A
Detailed steps for the change
Pre-Change Steps - steps to be completed before execution of the change
Estimated Time to Complete (mins) - 2
-
Set label changein-progress on this issue -
Ensure the feature flag configurable_diff_limits
is turned off or does not exist (/chatops run feature get configurable_diff_limits)
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 2
-
Navigate to Admin Area -> General -> Diff Limits -> Change the Maximum files in a diff to 3000 -
Navigate to Admin Area -> General -> Diff Limits -> Change the Maximum lines in a diff to 100000
Post-Change Steps - steps to take to verify the change
Estimated Time to Complete (mins) - 2
-
Refresh the page to ensure the limits are changed
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - 2
-
Change the max diff files to 1000 -
Change the max diff lines to 50000
Monitoring
Key metrics to observe
With the feature flag turned off, the diff limits change will not have any affect on production.
Summary of infrastructure changes
-
Does this change introduce new compute instances? -
Does this change re-size any existing compute instances? -
Does this change introduce any additional usage of tooling like Elastic Search, CDNs, Cloudflare, etc?
Summary of the above
Changes checklist
-
This issue has a criticality label (e.g. C1, C2, C3, C4) and a change-type label (e.g. changeunscheduled, changescheduled) based on the Change Management Criticalities. -
This issue has the change technician as the assignee. -
Pre-Change, Change, Post-Change, and Rollback steps and have been filled out and reviewed. -
Necessary approvals have been completed based on the Change Management Workflow. -
Change has been tested in staging and results noted in a comment on this issue. -
A dry-run has been conducted and results noted in a comment on this issue. -
SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall
and this issue and await their acknowledgement.) -
There are currently no active incidents.
Edited by Marin Jankovski