Skip to content

Fix work item due dates

Production Change

Change Summary

Discovered during gitlab-org/gitlab#501693 (comment 2215288388) that there are some work items in the database with garbage due dates:

  • Work item ID 155490741 has due date 20224-01-31
  • Work item ID 151827816 has due date 99999-09-05

image

This prevents a migration from finishing because Elasticsearch doesn't accept these dates.

This CR changes the dates of these two work items while proper validation is added before saving dates.

We propose changing:

  • Work item ID 155490741 from 20224-01-31 to 2024-01-31
  • Work item ID 151827816 from 99999-09-05 to 9999-09-05 - this is what it was before it was changed to 99999-09-05 and is accepted by Elasticsearch.

Change Details

  1. Services Impacted - ServiceSearch
  2. Change Technician - @arturoherrero
  3. Change Reviewer - @kassio
  4. Time tracking - 2 minutes
  5. Scheduled Date and Time - 20 November 08:00 UTC
  6. Downtime Component - None

Set Maintenance Mode in GitLab

If your change involves scheduled maintenance, add a step to set and unset maintenance mode per our runbooks. This will make sure SLA calculations adjust for the maintenance period.

Detailed steps for the change

Change Steps - steps to take to execute the change

Estimated Time to Complete (mins) - 2 minutes

  • Set label changein-progress /label ~change::in-progress
  • Start a production rails console
  • Get the first work item: work_item = WorkItem.find(155490741)
  • Grab the current due date and add it to a comment on this issue: work_item.due_date
  • Update the due date: work_item.update!(due_date: "2024-01-31")
  • Get the second work item: work_item = WorkItem.find(151827816)
  • Grab the current due date and add it to a comment on this issue: work_item.due_date
  • Update the due date: work_item.update!(due_date: "9999-09-05")
  • Set label changecomplete /label ~change::complete

Rollback

Rollback steps - steps to be taken in the event of a need to rollback this change

Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes

  • Change the due dates back to the originals:
  • WorkItem.find(155490741).update!(due_date: "20224-01-31")
  • WorkItem.find(151827816).update!(due_date: "99999-09-05")
  • Set label changeaborted /label ~change::aborted

Monitoring

Key metrics to observe

  • Metric: Metric Name
    • Location: Dashboard URL
    • What changes to this metric should prompt a rollback: Describe Changes

Change Reviewer checklist

C4 C3 C2 C1:

  • Check if the following applies:
    • The scheduled day and time of execution of the change is appropriate.
    • The change plan is technically accurate.
    • The change plan includes estimated timing values based on previous testing.
    • The change plan includes a viable rollback plan.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.

C2 C1:

  • Check if the following applies:
    • The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
    • The change plan includes success measures for all steps/milestones during the execution.
    • The change adequately minimizes risk within the environment/service.
    • The performance implications of executing the change are well-understood and documented.
    • The specified metrics/monitoring dashboards provide sufficient visibility for the change.
      • If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
    • The change has a primary and secondary SRE with knowledge of the details available during the change window.
    • The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval.
    • The labels blocks deployments and/or blocks feature-flags are applied as necessary.

Change Technician checklist

  • Check if all items below are complete:
    • The change plan is technically accurate.
    • This Change Issue is linked to the appropriate Issue and/or Epic
    • Change has been tested in staging and results noted in a comment on this issue.
    • A dry-run has been conducted and results noted in a comment on this issue.
    • The change execution window respects the Production Change Lock periods.
    • For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
    • For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention @sre-oncall and this issue and await their acknowledgement.)
    • For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
    • For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue. Mention @gitlab-org/saas-platforms/inframanagers in this issue to request approval and provide visibility to all infrastructure managers.
    • Release managers have been informed prior to any C1, C2, or blocks deployments change being rolled out. (In #production channel, mention @release-managers and this issue and await their acknowledgment.)
    • There are currently no active incidents that are severity1 or severity2
    • If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Calliope Gardner