[CR] [grpd] Enable non-tableflip Gitaly restarts on all Gitaly nodes
Production Change
Change Summary
As part of the effort to enable Gitaly's new transaction manager, tableflip upgrades, where two Gitaly processes run in tandem must be disabled.
We have had this rolled out to Canary and on the 10 Gitaly HDD without incident. Rollout the change to all Gitaly nodes
Roll out non-tableflip upgrades (gitlab-org/gitaly#5744 - closed)
Change Details
- Services Impacted - ServiceGitaly
- Change Technician - @f_santos
- Change Reviewer - @f_santos
- Time tracking - 1h
- Downtime Component -
Set Maintenance Mode in GitLab
If your change involves scheduled maintenance, add a step to set and unset maintenance mode per our runbooks. This will make sure SLA calculations adjust for the maintenance period.
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - ~30m
-
Set label changein-progress /label ~change::in-progress
03/07/24 02:00 UTC -
Merge https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/4859 -
Trigger a restart on one Gitaly node with knife ssh 'fqdn:gitaly-01-stor-gprd.c.gitlab-gitaly-gprd-83fd.internal' -C 1 -- sudo gitlab-ctl restart gitaly
-
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - ~30m
-
Revert https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/4859 -
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: Gitaly Per-Node Service Aggregated SLIs Error Ratio
- Location: https://dashboards.gitlab.net/d/gitaly-host-detail/gitaly3a-host-detail?orgId=1
- What changes to this metric should prompt a rollback: Significant change in this metric when a Gitaly restart occurs. Issues at other times are unlikely to be related to this change.
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary.
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed prior to any C1, C2, or blocks deployments change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Filipe Santos