2024-05-23: [production] Update haproxy cookbook
Production Change
Change Summary
Update the cookbooks for HAProxy on our production nodes.
This aims to resolve an issue on some of our HAProxy nodes where logrotate
attempts to run multiple instances, causing a race condition, and a build up of log backups.
This follows #18034 (closed) which applied the change to the non-production nodes.
Change Details
-
Services Impacted - HAProxy
gprd
chef nodes -
Change Technician -
@jcstephenson
- Change Reviewer - @donnaalexandra
- Time tracking - 30 minutes
- Downtime Component - none
Set Maintenance Mode in GitLab
If your change involves scheduled maintenance, add a step to set and unset maintenance mode per our runbooks. This will make sure SLA calculations adjust for the maintenance period.
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 30
-
Set label changein-progress /label ~change::in-progress
-
Verify HAProxy appears healthy bundle exec knife ssh -C 10 'gprd-base-haproxy' 'systemctl --no-pager status haproxy.service' # Check that we're able to hit the metrics port successfully bundle exec knife ssh -C 10 'gprd-base-haproxy' 'curl http://localhost:9101/metrics -Is'
-
Verify timers are enabled bundle exec knife ssh -C 10 'gprd-base-haproxy' 'systemctl --no-pager status logrotate.timer'
-
Merge https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/4797 -
Wait for environments to be published bundle exec knife environment show gprd
-
-
Run chef-client
on onehaproxy
node ingprd
bundle exec knife ssh -C 1 'haproxy-main-18-lb-gprd' sudo chef-client
-
Verify timer is disabled bundle exec knife ssh -C 1 'haproxy-main-18-lb-gprd' 'systemctl --no-pager status logrotate.timer'
-
Run chef-client
on allhaproxy
nodes ingprd
bundle exec knife ssh -C 5 'gprd-base-haproxy' sudo chef-client
-
Verify timers are disabled bundle exec knife ssh -C 10 'gprd-base-haproxy' 'systemctl --no-pager status logrotate.timer'
-
Wait and monitor chef-client
runs. -
Verify HAProxy still appears healthy bundle exec knife ssh -C 10 'gprd-base-haproxy' 'systemctl --no-pager status haproxy.service' # Check that we're able to hit the metrics port successfully bundle exec knife ssh -C 10 'gprd-base-haproxy' 'curl http://localhost:9101/metrics -Is'
-
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - 20
-
Create and merge revert MR of https://gitlab.com/gitlab-com/gl-infra/chef-repo/-/merge_requests/4797 -
Apply chef to all haproxy
nodes ingprd
bundle exec knife ssh 'gprd-base-haproxy' sudo chef-client
-
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: HAProxy
gprd
errors- Location: https://dashboards.gitlab.net/d/frontend-main/frontend3a-overview?orgId=1&var-PROMETHEUS_DS=e58c2f51-20f8-4f4b-ad48-2968782ca7d6&var-environment=gprd&var-stage=main
- What changes to this metric should prompt a rollback: Increase in errors or notable decrease in requests
- Metric: Chef client failures
- Location: https://dashboards.gitlab.net/d/000000231/chef-client?orgId=1&refresh=5m&var-environment=gprd&var-environment=ops
- What changes to this metric should prompt a rollback: Increase in errors
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary.
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed prior to any C1, C2, or blocks deployments change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.