[GSTG] Migrate duplicate jobs workload to redis-cluster-queues-meta
Production Change
Change Summary
This change issue details steps to migrate duplicate-jobs workload from redis-sidekiq
to redis-cluster-queues-meta
. See scalability#925 (closed)
Scheduled for: 25 Sept 0100h UTC
Change Details
- Services Impacted - ServiceSidekiq ServiceRedisSidekiq
- Change Technician - @schin1
- Change Reviewer - @alejandro
- Time tracking - 7h (6 hour waiting for ttl)
- Downtime Component - NA
Set Maintenance Mode in GitLab
If your change involves scheduled maintenance, add a step to set and unset maintenance mode per our runbooks. This will make sure SLA calculations adjust for the maintenance period.
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (7h)
-
Set label changein-progress /label ~change::in-progress
-
Merge k8s-workload MRs -
MR to set new secret: gitlab-com/gl-infra/k8s-workloads/gitlab-com!3070 (merged) -
MR to update redis config for redis-cluster-queues-meta: gitlab-com/gl-infra/k8s-workloads/gitlab-com!3071 (merged)
-
-
Enable feature-flag /chatops run feature set use_primary_and_secondary_stores_for_queues_metadata true --staging
to start dual-write -
Wait 6 hours for keys to timeout -
Enable feature-flag to cutover reads to redis-cluster-queues-meta
./chatops run feature set use_primary_store_as_default_for_queues_metadata true --staging
-
Observe for ~30 minutes -
Disable feature-flag to stop dual-write once the system is stable. /chatops run feature set use_primary_and_secondary_stores_for_queues_metadata false --staging
-
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (7h )
-
Enable use_primary_and_secondary_stores_for_queues_metadata
-
Wait 6 hours -
Disable use_primary_store_as_default_for_queues_metadata
-
Disable dual write via use_primary_and_secondary_stores_for_queues_metadata
-
Revert k8s MRs -
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
-
Metric: request rate
- Location: https://dashboards.gitlab.net/d/sidekiq-main/sidekiq-overview?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gstg&var-stage=main&var-shard=All
- What changes to this metric should prompt a rollback: if request rate spikes or dips anomalously, it could be due to wrongly deduplicated jobs
-
Metric: redis-cluster-queues-meta apdex and error rates,
- Location: https://dashboards.gitlab.net/d/redis-cluster-queues-meta-main/redis-cluster-queues-meta-overview?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gstg&var-shard=All
- What changes to this metric should prompt a rollback: not much since apdex will be inaccurate while the service starts receiving traffic for the very first time but it should not be consistently low. Error rates should be 0.
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary.
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncall
and this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed prior to any C1, C2, or blocks deployments change being rolled out. (In #production channel, mention
@release-managers
and this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Sylvester Chin