2023-08-24 Remove dangling migrations from Elasticsearch gitlab-production-migrations index
Production Change
Change Summary
This change will remove migrations in the gitlab-production-migrations index that do not exist in the codebase. The migration files were either reverted or refactored and exist under different documents
List out each migration:
-
20230720010000(DeleteWikisFromOriginalIndex) - gitlab-org/gitlab!127373 (merged) - Migration was halted and reverted. -
20230719094700(RemoveProjectsFromMainIndex) - gitlab-org/gitlab!127623 (merged) - The reason for this dangling migration is that we removed slicing and reduced the batch size. -
20230728104748(BackfillArchivedFieldInWikis) - gitlab-org/gitlab!129793 (merged) - Migration was stuck so it was reverted.
Change Details
- Services Impacted - ~"Service::Search"
- Change Technician - @terrichu
- Change Reviewer - @dgruzd
- Time tracking - 10 minutes (changes) + 10 minutes (rollback)
- Downtime Component - 0 minutes
Detailed steps for the change
Change Steps - steps to take to execute the change
Estimated Time to Complete (mins) - 2 minutes
Update with all delete commands to be run
DELETE /gitlab-production-migrations/_doc/20230720010000
DELETE /gitlab-production-migrations/_doc/20230719094700
DELETE /gitlab-production-migrations/_doc/20230728104748
-
Set label changein-progress /label ~change::in-progress -
Post an internal comment with the content for each document in the issue for Staging -
Delete each document on Staging - Dev Tools -
Post an internal comment with the content for each document in the issue for Production -
Delete each document on Production - Dev Tools -
Set label changecomplete /label ~change::complete
Rollback
Rollback steps - steps to be taken in the event of a need to rollback this change
Estimated Time to Complete (mins) - Estimated Time to Complete in Minutes
-
Re-insert the documents into the index -
Set label changeaborted /label ~change::aborted
Monitoring
Key metrics to observe
- Metric: Sidekiq logs
- Location: https://log.gprd.gitlab.net/app/kibana#/discover?_g=()&_a=(columns:!(_source),index:AW5F1e45qthdGjPJueGO,interval:auto,query:(language:kuery,query:''),sort:!(!(json.time,desc)))
- What changes to this metric should prompt a rollback: Errors when checking the migrations index
Change Reviewer checklist
-
Check if the following applies: - The scheduled day and time of execution of the change is appropriate.
- The change plan is technically accurate.
- The change plan includes estimated timing values based on previous testing.
- The change plan includes a viable rollback plan.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
-
Check if the following applies: - The complexity of the plan is appropriate for the corresponding risk of the change. (i.e. the plan contains clear details).
- The change plan includes success measures for all steps/milestones during the execution.
- The change adequately minimizes risk within the environment/service.
- The performance implications of executing the change are well-understood and documented.
- The specified metrics/monitoring dashboards provide sufficient visibility for the change.
- If not, is it possible (or necessary) to make changes to observability platforms for added visibility?
- The change has a primary and secondary SRE with knowledge of the details available during the change window.
- The change window has been agreed with Release Managers in advance of the change. If the change is planned for APAC hours, this issue has an agreed pre-change approval.
- The labels blocks deployments and/or blocks feature-flags are applied as necessary.
Change Technician checklist
-
Check if all items below are complete: - The change plan is technically accurate.
- This Change Issue is linked to the appropriate Issue and/or Epic
- Change has been tested in staging and results noted in a comment on this issue.
- A dry-run has been conducted and results noted in a comment on this issue.
- The change execution window respects the Production Change Lock periods.
- For C1 and C2 change issues, the change event is added to the GitLab Production calendar.
- For C1 and C2 change issues, the SRE on-call has been informed prior to change being rolled out. (In #production channel, mention
@sre-oncalland this issue and await their acknowledgement.) - For C1 and C2 change issues, the SRE on-call provided approval with the eoc_approved label on the issue.
- For C1 and C2 change issues, the Infrastructure Manager provided approval with the manager_approved label on the issue.
- Release managers have been informed prior to any C1, C2, or blocks deployments change being rolled out. (In #production channel, mention
@release-managersand this issue and await their acknowledgment.) - There are currently no active incidents that are severity1 or severity2
- If the change involves doing maintenance on a database host, an appropriate silence targeting the host(s) should be added for the duration of the change.
Edited by Terri Chu