Audit / look into better separation of chef roles for prod/non prod/staging
Corrective actions 5 and 6 from: https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8528
- Perform an audit to see what roles are currently shared by production/staging, if there are role files that are shared we should split them. Cameron: Doesn’t this subvert the intended use of environments in chef? And could this introduce mistakes when moving changes from one role to another? Nice to have
- Investigate waiting for chef convergence to complete on staging, before allowing an update on a production role. Very hard to do with chef - Nice to have => Gerir: the separation of staging vs prod should really be a must have -> adding to DNA next week. Dependant on item 5 above
As a first step, this issue should be the investigation of what roles we have that overlap between GitLab.com prod and other "prod" - customers, version, license environments. A recommendation of how to split those overlapping roles should be made and follow on issue should be attached for that action.