Upgrade to Redis 5
Upgrading to Redis 5 will resolve two problems:
Disabling risky redis commands
As part of gitlab-org/omnibus-gitlab#4478 (closed), omnibus-gitlab will begin disabling the KEYS
command in redis by default. This change will cause gitlab-ctl reconfigure
to restart redis when the new package is deployed.
The change is currently on track to be released as part of %12.2.
Per a discussion with @jarv, it seems that the omnibus version is locked for the redis nodes. I'm opening this issue to let you know of the upcoming change so you can plan accordingly.
Ensuring version match between non-production and production environments
GitLab 12.7 ships with Redis 5.x. We need to look at upgrading both our Sentinel and Redis nodes, which are locked at v11.11.5-ee (https://dashboards.gitlab.net/d/CRNfDC7mk/gitlab-omnibus-versions?orgId=1&refresh=5m). This upgrade should provide significant performance and bug fixes, and allow us to upgrade to Sidekiq 6.0.