Tagging failure leaves us in an inconsistent state where VERSION files are updated incorrectly
The correct one happened on the first tag, https://ops.gitlab.net/gitlab-org/release/tools/-/jobs/964580
2020-03-05 20:24:25.878061 I ReleaseTools::Release::OmnibusGitlabRelease -- Bumping version -- {:file_name=>"VERSION", :version=>"12.8.3-ee"}
Then, that job failed so it was retried where another version bump happened but used the wrong release https://ops.gitlab.net/gitlab-org/release/tools/-/jobs/964633
2020-03-05 20:40:47.003417 I ReleaseTools::Release::OmnibusGitlabRelease -- Bumping version -- {:file_name=>"VERSION", :version=>"12.9.0-pre"
On the retry, since the tag already existed for 12.8.3 we did not use a 12-8-stable checkout of gitlab-org/gitlab
for version updates, instead we grabbed the versions from master
.