multiple auto-deploys without any changes
On the omnibus auto-deploy branch we see these commits with tags:
commit 9bfb32c38ada4cc663d18da9f4979b68657851ba (tag: 12.0.9667+c8670321fca.9bfb32c38ad)
Author: 🤖 GitLab Bot 🤖 <gitlab-bot@gitlab.com>
Date: Mon May 13 00:29:10 2019 +0000
Update component versions
commit 9c45d2df8b542082061582cec39b5cae4b6d503d (tag: 12.0.9658+c8670321fca.9c45d2df8b5)
Author: 🤖 GitLab Bot 🤖 <gitlab-bot@gitlab.com>
Date: Sun May 12 16:54:03 2019 +0000
Update component versions
commit 0b0c1633727f952eb9966219fbb819922df9c3d5 (tag: 12.0.9653+c8670321fca.0b0c1633727)
Author: 🤖 GitLab Bot 🤖 <gitlab-bot@gitlab.com>
Date: Sun May 12 14:56:17 2019 +0000
Update component versions
commit b798a006de110925b0a8d60c473e80b05b7970dc (tag: 12.0.9652+c8670321fca.b798a006de1)
Author: 🤖 GitLab Bot 🤖 <gitlab-bot@gitlab.com>
Date: Sun May 12 14:33:41 2019 +0000
Update component versions
which results in auto-deploy builds and preprod deployments.
- c8670321fca is the ee ref
- b798a006de1 is the omnibus ref
- These are all empty commits
This is happening because after we find the latest green ee commit we go to update the versions which are the same as it was before, so we have an empty commit which the triggers the build.
The fix for this is to only make a "update component versions" commit if there are changes. If not, then tag, and if there is already the same tag (in this case there is) we would not do anything which would prevent a new auto-deploy.
Edited by John Jarvis