Release-tools does not accurately provide deployment information on cherry picked MR's
Problem Statement
During an incident we were utilizing chatops to determine if a fix had been deployed. Chatops was reporting that the fix deployed, but release-tools is not using the correct information to decide this, thus leading developers and the EOC astray. Release-tools does not utilize the appropriate sha
when performing the check and instead is only looking at the branch to determine where auto-deploy is in the process. This leads users of chatops to receive incorrect information. Example of the merge commit vs the cherry-pick commit:
Timeline
- Auto-deploy branch
15-2-auto-deploy-2022071409
is on it's way out to production canary stage (already deployed into staging canary) - MR is cherry-picked into the auto-deploy branch - gitlab-org/gitlab!92411 (comment 1026495759)
- User runs the chatops command for fix which reports this MR is deployed to production canary: https://gitlab.slack.com/archives/C101F3796/p1657804413331869 (internal)
Reference
- Incident: production#7437 (closed)
- MR Fix: gitlab-org/gitlab!92411 (merged)
As this is a troubleshooting tool that is not operating correctly, I'm marking this as a corrective action.