Implement the changes necessary for dedicated to deploy internal packages

Context

Based on the findings from understanding the Dedicated impact of tagging a package with a new notation, we need to make sure the changes are reflected on the necessary components for dedicated. Thus, this issue is to track these changes.

Proposal

The Dedicated offering has many components. The components that require changes to accept the new packages easily are:

• Instrumentor
• Tenant model schema
• Switchboard

These are the only components that require changes. This issue will be the governing issue for the three implementation issues.

Tenant model schema changes

This is a JSON schema for the Gitlab Dedicated tenant model, generated by another component called switchboard; we need to adapt the schema to accept the new notation and not throw errors (while maintaining fallback for regular packages ?).

https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/tenant-model-schema/-/blob/main/json-schemas/tenant-model.json?ref_type=heads#L250-267

Instrumentor changes

This is the component needed to provision and configure the tenant, we need to adapt some parts that accepts the images/package to be fetched.

https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/instrumentor/-/blob/main/common/jsonnet/gitlab-release-utils.libsonnet?ref_type=heads#L22-33

Switchboard

This is the component that generates the tenant model based on user input.

https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/switchboard/-/blob/main/app/models/concerns/version_validations.rb#L7-9

Important points to consider

• The omnibus package and the CNG package should be the same. For example, the sandbox got tested with different package name than the CNG one, hence changes in multiple places in Instrumentor
  • https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/instrumentor/-/merge_requests/4181/diffs#da1e8b4b54dd1372e9e864b8aab1f43164e11bad
• We need to guarantee compatibility with regular packages (from patches) and internal packages (from internal releases)

Exit criteria

• Instrumentor change issue created.
• Tenant model schema change issue created.
• Switchboard change with issue created.