Some Gitaly servers were not HUP'd after upgrade
corrective action for production#4810 (closed)
In https://ops.gitlab.net/gitlab-com/gl-infra/deployer/-/jobs/4023581
It is clear that not all Gitaly servers were hup'd after upgrade, these servers report a HUP in the deploy log:
TASK [*gprd 14.0.202106040320-4ac72f3a52d.fca6a2aae6e* HUP services that have a version change] ***
changed: [file-54-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-56-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-57-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-58-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-55-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-60-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
changed: [file-59-stor-gprd.c.gitlab-production.internal] => (item=gitaly)
The condition for HUP checks the version and uptime:
######## Services that require HUPs ##############################
- name: "{{ info }}HUP services that have a version change"
become: true
command: "gitlab-ctl hup {{ item | replace('_','-') }}"
register: hup_result
check_mode: false
when:
- "post_install_status['service_' + item] == 'up'"
- "post_install_status['version_' + item] != pre_install_status['version_' + item]"
- "post_install_status['uptime_' + item] | int > pre_install_status['uptime_' + item] | int"
with_items:
- gitaly