GItaly bump merge request approved but not set as merge when pipeline succeed
In gitlab-org/gitlab!46408 (merged) the merge request was not set in "merge when pipeline succeeds" state.
According to the following notes timeline, it seems possible that the async job processing the incoming commit (version bump) was slower than us approving and setting "merge when pipeline succeeds".
We already verify that the pipeline is started before approving the MR, what could have prevented the "merge when pipeline succeeds" flag to be set?
Extra details:
- original pipeline job on ops
- failure message:
2020-10-29 04:05:56.588400 I ReleaseTools::Services::UpdateComponentService -- Updating component version -- {:component=>"gitaly", :branch=>"release-tools/update-gitaly", :version=>"6aabab39e06f8a4f786a99449a49d5f0cb332310"}
2020-10-29 04:06:02.831257 D ReleaseTools::GitlabClient -- [HTTParty] [2020-10-29 04:06:02 +0000] 201 "POST https://gitlab.com/api/v4/projects/gitlab%2Dorg%2Fgitlab/repository/commits" 753
2020-10-29 04:06:02.831430 I ReleaseTools::Tasks::Components::UpdateGitaly -- Accepting merge request -- {:merge_request=>"https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46408"}
2020-10-29 04:06:03.161289 I ReleaseTools::Services::MergeWhenPipelineSucceedsService -- Approving merge request -- {:merge_request=>"https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46408"}
2020-10-29 04:06:03.641086 I ReleaseTools::Services::MergeWhenPipelineSucceedsService -- Waiting for a merge request pipeline
2020-10-29 04:06:33.033506 F Rake::Task -- Task failed -- Exception: ReleaseTools::Services::MergeWhenPipelineSucceedsService::PipelineNotReadyError: ReleaseTools::Services::MergeWhenPipelineSucceedsService::PipelineNotReadyError
/builds/gitlab-org/release/tools/lib/release_tools/services/merge_when_pipeline_succeeds_service.rb:106:in `block in
ReleaseTools::Services::MergeWhenPipelineSucceedsService::PipelineNotReadyError: ReleaseTools::Services::MergeWhenPipelineSucceedsService::PipelineNotReadyError
/builds/gitlab-org/release/tools/lib/release_tools/services/merge_when_pipeline_succeeds_service.rb:106:in `block in wait_for_mr_pipeline_to_start'
Edited by Alessio Caiazza