Cleanup code post rolling out Sidekiq circuit breaker
Overview
This issue tracks the cleanup work needed after successfully rolling out the Sidekiq circuit breaker feature. Once all related feature flags are fully rolled out, we need to remove them from the codebase and clean up associated documentation.
Prerequisites
All feature flags linked below must be fully rolled out before proceeding with cleanup.
Tasks
Feature Flag Removal (in order)
-
Remove feature flag from [FF] `sidekiq_concurrency_limit_middleware_v2` ... (gitlab-org/gitlab#565604) - MR gitlab-org/gitlab!211285 (merged) -
Remove ConcurrencyLimit::WorkersMapclass and its usage. It's no longer used as part of thesidekiq_concurrency_limit_middleware_v2rollout above. - MR gitlab-org/gitlab!211755 -
Remove feature flag from [FF] `use_max_concurrency_limit_percentage_as_d... (gitlab-org/gitlab#553604) - MR gitlab-org/gitlab!211775 -
Remove feature flag from [FF] `concurrency_limit_current_limit_from_redi... (gitlab-org/gitlab#549836) - MR gitlab-org/gitlab!211804 -
Remove envvar REORDER_DUPLICATE_JOBS_AND_CONCURRENCY_LIMIT_MIDDLEWARE(gitlab-org/gitlab!208142 (diffs)) - MR gitlab-org/gitlab!211908-
Remove REORDER_DUPLICATE_JOBS_AND_CONCURRENCY_LIMIT_MIDDLEWARE from k8s-workloads - gitlab-com/gl-infra/k8s-workloads/gitlab-com!4920
-
Configuration cleanup
-
RemoveGITLAB_SIDEKIQ_MAX_REPLICASenvironment variables defined ink8s-workloadsGITLAB_SIDEKIQ_MAX_REPLICASwill be kept around in k8s-workloads for now on .com. Once #237 is done, we can remove it in k8s-workloads.
Documentation Cleanup
-
Remove reference to concurrency_limit_current_limit_from_redisfeature flag from runbooks
Notes
Edited by Marco Gregorius