Unverified Commit f757ece7 authored by Denys Mishunov's avatar Denys Mishunov 🔴
Browse files

doc: example for the reviews discipline

parent 9c6566f8
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -53,7 +53,9 @@ Improve stability, predictability, and quality of the DAP codebase while impleme
1. Reviews and Merge Discipline

    * Up until the code is considered stabilized (subject to another evaluation), all Merge Requests require at least two reviewers from the relevant specialty (BE or FE).
    * No single-review merges unless explicitly approved for high-severity (S1) fixes.
    * No single-review merges unless explicitly approved for high-severity (S1) fixes. Every MR has to have 2 approvals for the main functional discipline(s) of the MR (frontend and/or backend). Examples:
      * if an MR requires both frontend and UX reviews, it's expected to have 2 frontend reviews and 1 UX ([for MRs from teams that include a Product Designer](https://docs.gitlab.com/development/code_review/#reviewer-roulette))
      * if an MR requires both backend and frontend reviews it is expected to have 2 frontend and 2 backend reviews

2. Quality Over Assumptions