Commit eb1f10bc authored by Chaoyue Zhao's avatar Chaoyue Zhao 🌴 Committed by Michelle Gill
Browse files

Add guidelines to communicate PTO on assigned reveiws

parent 5ffd58b4
Loading
Loading
Loading
Loading
+12 −0
Original line number Diff line number Diff line
@@ -23,6 +23,18 @@ You can also help community contributors get their merge requests ready, by beco

Note that while all engineers can review all merge requests, the ability to *accept* merge requests is restricted to maintainers.

### Managing Review Assignments Before PTO

Before taking paid time off, reviewers should:

- Check all MR reviews assigned to you on your last working day before PTO
- Respect the [review SLO](#review-response-slo) by either:
  - Leaving a message on the MR with your PTO dates and expected return
  - Reassigning the review to another available reviewer
- If you're unable to complete a review before your PTO begins, notify the MR author directly

This ensures merge requests don't become blocked during your absence.

## Maintainer

Maintainers are GitLab engineers who are experts at code review, know the GitLab product and codebase very well, and are empowered to accept merge requests in one or several [GitLab Engineering Projects](/handbook/engineering/projects/).
+1 −0
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ In line with our value of transparency, communicate broadly when you will be awa
- Add an out-of-office automated Gmail response including your away dates and identify someone to contact in your absence.
- Consider sharing your planned time off as an FYI in your team's Slack channel(s), especially if you lead a team.
- [Schedule reminder messages](https://slack.com/help/articles/201457107-Send-and-read-messages) in Slack to notify your team about pending items while you're away
- Check all assigned MR reviews on your last working day before PTO. For each review, either complete the review if time permits, or leave a comment with your PTO dates and expected return, or reassign to another available reviewer. 
- If your team has a specific scheduling calendar, update it with your time off plans.

{{% /details %}}