Commit ba0c6a76 authored by Ian Ernst's avatar Ian Ernst Committed by Dan Plumbley
Browse files

Make labs more consistent with pipeline editor fix

parent e04cbe6a
Loading
Loading
Loading
Loading
+2 −4
Original line number Diff line number Diff line
@@ -235,11 +235,9 @@ To make these changes, we will push a `config.toml` file to the runner.

1. Commit your `config.toml` file.

1. Select your `.gitlab-ci.yml` file.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. After the `gitlab-runner register` command, add the following into the script:
1. Inside your .gitlab-ci.yml file, after the `gitlab-runner register` command, add the following into the script:

      ```yml
      - scp config.toml root@$ip:/etc/gitlab-runner/config.toml
+2 −6
Original line number Diff line number Diff line
@@ -58,9 +58,7 @@ In this example, let's look at how we can cancel the pipeline in the case where

1. Navigate to your `Node` project repository.

1. Select `.gitlab-ci.yml`.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. Just below the stages section of your `.gitlab-ci.yml` file, add a workflow to auto cancel the jobs.

@@ -91,9 +89,7 @@ In this example, let's look at how we can cancel the pipeline in the case where

1. Navigate to your repository.

1. Select `.gitlab-ci.yml`.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. Remove the `test fail` job. Your `.gitlab-ci.yml` file will look like this:

+1 −3
Original line number Diff line number Diff line
@@ -68,9 +68,7 @@ test linearsearch:

1. Navigate to your project repository.

1. Select the `.gitlab-ci.yml` file.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. In our current `.gitlab-ci.yml` file, all of the tests contain the same set of artifacts. Instead of defining the artifacts at each job, you can instead first create a hidden job with the definition:

+2 −6
Original line number Diff line number Diff line
@@ -17,9 +17,7 @@ For this task, we will be creating a web application to run in our review enviro

1. Navigate to your project repository.

1. Select your `.gitlab-ci.yml` file.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. When we add express code into our `index.js` file, our tests will no longer be able to run against `index.js`, since running this will create a webserver that waits for connections. Thus, let's remove the `install deps`, `test binarysearch` and the `test linearsearch` jobs from the file. Remove the jobs from the `.gitlab-ci.yml` file, and select **Commit changes**.

@@ -71,9 +69,7 @@ For this task, we will be creating a web application to run in our review enviro

1. Navigate back to your code repository.

1. Select your `.gitlab-ci.yml` file.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. Paste the copied `deploy_review` job at the end of the `.gitlab-ci.yml` file.

+1 −3
Original line number Diff line number Diff line
@@ -61,9 +61,7 @@ Follow these steps to set up and use a feature flag:

1. To test running this, we will test running the script.

1. Open your `.gitlab-ci.yml` file.

1. Select **Edit > Edit in pipeline editor**.
1. Select **Build > Pipeline Editor**.

1. Replace your whole `.gitlab-ci.yml` file with the following code:

Loading