Commit 6fc98785 authored by Saru Thuraiman's avatar Saru Thuraiman
Browse files

Fix a few typos in OpenBao ARDs

parent fe97d354

content/handbook/engineering/architecture/design-documents/secret_manager/decisions/002_gcp_kms.md

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ store asymmetric keys belonging to each vault. 


## Decision



We decided to rely on Google CLoud Platform (GCP) Key Management Service (KMS) to manage the asymmetric keys

We decided to rely on Google Cloud Platform (GCP) Key Management Service (KMS) to manage the asymmetric keys

used by the GitLab Secrets Manager vaults.



Using GCP provides a few advantages:

content/handbook/engineering/architecture/design-documents/secret_manager/decisions/004_stateless_kms.md

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ Google's Cloud KMS, depending on the tier too. 
## Consequences



1. All private keys are going to be stored in Google's Cloud KMS.

1. Multi-tier protection will be implemented, with higher tries offering more protection.

1. Multi-tier protection will be implemented, with higher tiers offering more protection.

1. Protection tier will be defined on per-organization level on the GitLab Rails Service side.

1. Depending on the protection level used, symmetric decryption keys can be in-memory cached.

1. The symmetric key's cache must not be valid for more than 24 hours..

content/handbook/engineering/architecture/design-documents/secret_manager/decisions/005_secrets_key_structure.md

+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ toc_hide: true 


## Context



In GitLab, we have a hierarchical structure for projects and their parent namespaces wherein names can be identical in certain parts of the paths. We want to ensure that there are no conflicts with secrets paths across the hierarchy and across all customers when we store then in OpenBao.

In GitLab, we have a hierarchical structure for projects and their parent namespaces wherein names can be identical in certain parts of the paths. We want to ensure that there are no conflicts with secrets paths across the hierarchy and across all customers when we store them in OpenBao.



## Decision