Changes for content/handbook/engineering/workflow/code-review.md: 5 added lines, 13 removed lines.
Original line number
Diff line number
Diff line
@@ -565,17 +565,9 @@ As the author of an MR you should reassign to another reviewer or maintainer if
## Code Owner approvals
Some GitLab projects use GitLab's [CODEOWNERS file feature](https://docs.gitlab.com/ee/user/project/codeowners/) to manage approvals for specific file paths and types. In the `gitlab-org/gitlab` project, [we use a combination of CODEOWNERS approval rules plus MR approval settings](https://docs.gitlab.com/ee/development/code_review.html#merging-a-merge-request) in order to follow segregation of duties best practices. This section describes the process for updating the eligible approvers for CODEOWNERS changes for the `gitlab-org/gitlab` project.
Some GitLab projects use GitLab's [CODEOWNERS file feature](https://docs.gitlab.com/ee/user/project/codeowners/) to manage approvals for specific file paths and types.
The Code Owners for the [CODEOWNERS file](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/CODEOWNERS) itself are managed with a rule in the file. For example:
There are two ways to update the Code Owner(s) of the `CODEOWNERS` file:
1. Update the membership of a group that already has the ability to approve CODEOWNERS changes via the [standard access request process](/handbook/eta/corporate-it/end-user-services/access-requests/access-requests/).
1. Open a merge request to update the relevant lines. An existing Code Owner will have to approve the merge request. You are also encouraged to ping a security compliance team member for visibility.
The `@gitlab-org/development-leaders` group consists of team members from Senior Managers and above in the management track, and Distinguished Engineer and above in the individual contributor track in the development departments within Engineering.
In the `gitlab-org/gitlab` project, we use a combination of
