Commit 0b642a3c authored by Lohit Peesapati's avatar Lohit Peesapati 2️⃣ Committed by David Dieulivol
Browse files

Remove review apps references from engineering handbook space

parent 79d54a22

content/handbook/engineering/architecture/design-documents/gitlab_agent_deployments/_index.md

+1 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ The microservice project setup can be improved by [Multi-Project Deployment Pipe 
- Environments can be created within the application projects. It gives more visibility of environments for developers.

- Deployment Project can be managed under Operator group. More segregation of duties.

- Users don't need to set up [RBAC to restrict CI/CD jobs](https://docs.gitlab.com/ee/user/clusters/agent/ci_cd_workflow.html#restrict-project-and-group-access-by-using-impersonation).

- This is especially helpful for [dynamic environments](https://docs.gitlab.com/ee/ci/environments/index.html#create-a-dynamic-environment) like review apps.

- This is especially helpful for [dynamic environments](https://docs.gitlab.com/ee/ci/environments/index.html#create-a-dynamic-environment).



```mermaid

flowchart LR

content/handbook/engineering/devops/verify/pipeline-execution/_index.md

+1 −1
Original line number Diff line number Diff line
@@ -98,7 +98,7 @@ classDiagram 
| Fail Fast Testing |   |

| Accessibility testing | [~testing::accessibility](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=testing%3A%3Aaccessibility&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20) |

| Usability testing | [~testing::usability](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=testing%3A%3Ausability&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20) |

| Review apps | [~testing::review apps](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=testing%3A%3Areview%20apps&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20) |

| Review apps (deprecated) | [~testing::review apps](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=testing%3A%3Areview%20apps&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20) |

| Visual review tool (deprecated) | [~testing::visual review tool](https://gitlab.com/gitlab-org/gitlab/-/issues/?label_name%5B%5D=testing%3A%3Avisual%20review%20tool) |

| Scheduled pipelines | [~pipeline schedules](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=pipeline%20schedules&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20)  |

| Pipeline efficiency | [~ci::scaling](https://gitlab.com/gitlab-org/gitlab/-/issues/?sort=milestone_due_desc&state=opened&label_name%5B%5D=ci%3A%3Ascaling&label_name%5B%5D=group%3A%3Apipeline%20execution&first_page_size=20)  |

content/handbook/engineering/infrastructure-platforms/developer-experience/design-documents/browser_performance_testing/_index.md

+2 −2
Original line number Diff line number Diff line
@@ -194,7 +194,7 @@ Leverage and integrate with the existing GitLab Browser Performance Testing (GBP 
### Phase 2: MR-Level Integration



1. **Leverage Existing CI/CD Resources**

   * Utilize existing CI/CD review apps or CNG instances rather than spinning up new environments

   * Utilize existing CI/CD CNG instances rather than spinning up new environments

   * Execute Sitespeed tests after E2E tests complete on the same environment

   * Consider building dedicated environments with CNG orchestrator if sharing with E2E tests introduces result variability

2. **Baseline Establishment**
@@ -234,7 +234,7 @@ Leverage and integrate with the existing GitLab Browser Performance Testing (GBP 
### Environment Strategy



1. **MR Testing**:

   * Use existing review apps or CNG instances after E2E tests complete

   * Use existing CNG instances after E2E tests complete

   * Test against a controlled, consistently seeded environment

   * Compare directly against master branch baseline on the same environment type

   * Leverage dynamic baselines from the Performance Results Datastore

content/handbook/engineering/infrastructure-platforms/developer-experience/onboarding.md

+0 −1
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ and complete the issue. 
* CI infrastructure for CE and EE

  * [GitLab project pipelines](https://docs.gitlab.com/ee/development/testing_guide/end_to_end/)

  * [Testing from CI](https://docs.gitlab.com/ee/development/cicd/)

  * [Review Apps](https://docs.gitlab.com/ee/development/testing_guide/review_apps.html)

* Tests statistics

  * [Redash Test Suite Statistics](https://redash.gitlab.com/dashboard/test-suite-statistics)

* Insights dashboard

content/handbook/engineering/infrastructure-platforms/environments/_index.md

+0 −8
Original line number Diff line number Diff line
@@ -41,14 +41,6 @@ Currently there are two main uses for the .org environment: 


This is a critical piece of infrastructure that is always growing in size due to build artifacts. There are discussions to make a new build server where nightly CE/EE builds can be deployed or to move the infra repos to a new host that would be a separate (not gitlab.com) EE instance. Although the environment has dev in its domain name, don't refer to it as dev, since that could be confused with a local development environment.



### Review Apps



| **Name** | **URL** | **Purpose** | **Deploy** | **Database** | **Terminal access** |

| ---- | --- | ------- | ------ | -------- | --------------- |

| Review apps | various | Test proposal | on commit | Fixture | Review app owner |



Ephemeral app environments that are created dynamically every time you push a new branch up to GitLab, and they're automatically deleted when the branch is deleted. Single container with limited access.



### Ops



| **Name** | **URL** | **Purpose** | **Deploy** | **Database** | **Terminal access** |