Fix review app path
All threads resolved!
Following some changes to review apps recently (!5388 (merged)), the environment path selected means that GitLab no longer sees these as review app environments internally. It seems they need to use review/
as the path so that things like https://docs.gitlab.com/ee/api/environments.html#delete-multiple-stopped-review-apps can work to manage these environments.
Also, !5327 (merged) set all deployments as production
for deployment tier, which was fine at that time. But since the change above, review apps are re-using the pages
job, and now they are all being labeled as deployments to production. We can remove this hard coding, because GitLab automatically sets the tier to production
when the environment name is production
. Otherwise, our DORA metrics are probably being skewed by review app deployments: https://docs.gitlab.com/ee/user/analytics/dora_metrics.html#deployment-frequency
Please verify the check list and ensure to tick them off before the MR is merged.
Maintained by
section on the page being edited