Fix review app path

Why is this change being made?

Following some changes to review apps recently (!5388 (merged)), the environment path selected means that GitLab no longer sees these as review app environments internally. It seems they need to use review/ as the path so that things like https://docs.gitlab.com/ee/api/environments.html#delete-multiple-stopped-review-apps can work to manage these environments.

Also, !5327 (merged) set all deployments as production for deployment tier, which was fine at that time. But since the change above, review apps are re-using the pages job, and now they are all being labeled as deployments to production. We can remove this hard coding, because GitLab automatically sets the tier to production when the environment name is production. Otherwise, our DORA metrics are probably being skewed by review app deployments: https://docs.gitlab.com/ee/user/analytics/dora_metrics.html#deployment-frequency

• Related to Move development/contributing docs to docsy the... (!5327 - merged)
• Related to Improve review apps (!5388 - merged)
• Related to Update review app environment with a slash '/' (!7082 - merged)

Author and Reviewer Checklist

Please verify the check list and ensure to tick them off before the MR is merged.

• Provided a concise title for this Merge Request (MR)
• Added a description to this MR explaining the reasons for the proposed change, per say why, not just what
  • Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
• Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI)
  • If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the Maintained by section on the page being edited
  • If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
  • The when to get approval handbook section explains the workflow in more detail
• For transparency, share this MR with the audience that will be impacted.
  • Team: For changes that affect your direct team, share in your group Slack channel
  • Department: If the update affects your department, share the MR in your department Slack channel
  • Division: If the update affects your division, share the MR in your division Slack channel
  • Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR
    • For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter

Commits

• Fix review app path

---

added HandbookContent Technical Writing labels

assigned to @marcel.amirault

changed the description

added 1 commit

• 7c435ff8 - Fix review app path

Compare with previous version

added 1 commit

• 61ac6731 - Fix deployment tier

Compare with previous version

changed the description

added 1 commit

• 2be63a58 - Fix deployment tier

Compare with previous version

changed the description

added 1 commit

• 17308555 - Remove DORA note

Compare with previous version

@cynthia One step towards being able to better maintain our review app environments, WDYT?

See https://gitlab.com/gitlab-com/content-sites/handbook/-/environments to see how it looks now, while https://gitlab.com/gitlab-com/www-gitlab-com/-/environments is how it should look.

mentioned in merge request gitlab-com/www-gitlab-com!135872 (merged)

requested review from @leetickett-gitlab

When you are ready for this MR to be reviewed, please assign a relevant maintainer, or tag @gitlab-com/content-sites/handbook-tools as it modifies .gitlab-ci.yml, assets, config, templates, or scripts.

This message was generated automatically. You're welcome to improve it.

added HandbookOperations label and removed HandbookContent label

added 1 commit

• e5502ff6 - Apply 2 suggestion(s) to 1 file(s)

Compare with previous version

added maintenancepipelines typemaintenance labels

changed milestone to %17.4

resolved all threads

added 1 commit

• 47c21a50 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

approved this merge request

LGTM- thanks all

started a merge train

merged

mentioned in commit 916d9612

mentioned in issue gitlab-com/content-sites/handbook-tools/maintenance-tasks#7 (closed)