Update review app with pages prefix FF on
Fixes review apps now that the fix_pages_ci_variables
feature flag has been turned on, which changes the behaviour of the variable.
Re-implements changes from !11085 (merged) which were merged the last time the feature flag was turned on with some minor changes based on the current variable behaviour.
Closes #437 (closed)
Merge request reports
Activity
changed milestone to %17.9
added HandbookOperations maintenanceworkflow typemaintenance labels
assigned to @cynthia
When you are ready for this MR to be reviewed, please assign a relevant maintainer, or tag
@gitlab-com/content-sites/handbook-tools
as it modifies.gitlab-ci.yml
,assets/
,config/
,scripts/
,issue_templates/
, ormerge_request_templates/
.This message was generated automatically. Improve it or delete it.
added deploy-review-app-always label
mentioned in merge request !11722 (closed)
requested review from @siddharthkannan
@jaime since you reviewed the previous related MR, would you mind doing a maintainer review/approval?
🙇 @cynthia I'm happy to merge this, but we will need to revert again if
fix_pages_ci_variables
gets disabled again. Let's keep an eye on [Feature flag] Rollout of `fix_pages_ci_variables` (gitlab-org/gitlab#503993 - closed).@janis @vshushlin could you please let us know if anything changes?
@jaime, Sure! The feature flag removal MR is about to be merged though, so I don't expect any further hiccups at this time: gitlab-org/gitlab!180697 (merged)
requested review from @jaime
started a merge train
mentioned in commit 14180efe