Initial Architecture Design document for GitHub integration
Why is this change being made?
Architecture Design Doc for Gitlab CI/CD Integration with Github SCM
Initial PoC: gitlab-org/gitlab!173056 (closed)
Please see !10793 (closed) for a revised approach with GitHub Actions in tandem with GitHub Apps : We do not want to use GitHub Actions due to the cost and headache for developers
Author and Reviewer Checklist
Please verify the check list and ensure to tick them off before the MR is merged.
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
For transparency, share this MR with the audience that will be impacted. -
Team: For changes that affect your direct team, share in your group Slack channel -
Department: If the update affects your department, share the MR in your department Slack channel -
Division: If the update affects your division, share the MR in your division Slack channel -
Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR - For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter
-
Commits
- Initial Architecture Design document for GitHub integration
Merge request reports
Activity
added HandbookContent label
assigned to @mfanGitLab
added grouppipeline execution label
added devopsverify sectionci labels
changed milestone to %17.7
1 Message This merge request might require a review from a Coach Engineer. Architecture Evolution Review
This merge request might require a review from a Coach Engineer.
The following files, which might require the additional review, have been changed:
content/handbook/engineering/architecture/design-documents/ci_pipelines_for_github/_index.md
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****- Resolved by Max Fan
Using combined codequality.json: vale-codequality.json handbook-codequality.json linkcheck.json
Pipeline Failure - Linting ErrorsOne of the linters has reported errors and as a result the pipeline has failed. Once the pipeline completes, you'll find the code quality report above which can link you to where the error is in your code. Additionally, below you'll find a table of the errors. The table has links to the lint rules so you can find more information on how to fix the issue(s).
Rule File Line Error IMAGES content/handbook/engineering/architecture/design-documents/ci_pipelines_for_github/images/GithubGitlabWorkflow.png 0 The image content/handbook/engineering/architecture/design-documents/ci_pipelines_for_github/images/GithubGitlabWorkflow.png
is not in the /static/images directory. Please move it to the correct location. If you are renaming, moving, or deleting pages, please check the Code Quality report, or the hugolint job's artifact files, to see if there are any related broken links.If you need more help please reach out on Slack in #mr-buddies.
Edited by ****
added 1 commit
- 5a736f27 - Initial Architecture Design document for GitHub integration
Hey @allison.browne !
Can you help do a first review here before I open it up to #architecture channelHey @hfyngvason !
Can you help do a first review here before I open it up to #architecture channelrequested review from @hfyngvason and @allison.browne
mentioned in issue gitlab-org/gitlab#493378 (closed)
mentioned in issue gitlab-org/gitlab#460503
- Resolved by Max Fan
- Resolved by Max Fan
- Resolved by Max Fan
- Resolved by Max Fan
- Resolved by Max Fan
- Resolved by Rutvik Shah