danger-review
Passed Started
by
@mfanGitLab

Max Fan
1Running with gitlab-runner 17.7.0~pre.103.g896916a8 (896916a8)2 on blue-4.saas-linux-medium-amd64.runners-manager.gitlab.com/default DS1-6aDu, system ID: s_eacbc5a4b5863 feature flags: FF_USE_FASTZIP:true4Resolving secrets6Using Docker executor with image ruby:3.3 ...7Pulling docker image ruby:3.3 ...8Using docker image sha256:a284feacf6f452a0551b78dbc7bbdfc1e40204047668d8a7042f67a04536533f for ruby:3.3 with digest ruby@sha256:2fd25434f88fd15628fec640bec8e40201128aadd00157e7a3f88a25567ba713 ...10Running on runner-ds1-6adu-project-42817607-concurrent-0 via runner-ds1-6adu-s-l-m-amd64-1739986219-ff9bf786...12Fetching changes...13Initialized empty Git repository in /builds/gitlab-com/content-sites/handbook/.git/14Created fresh repository.15Checking out 00adee52 as detached HEAD (ref is refs/merge-requests/10202/merge)...16Skipping Git submodules setup17$ git remote set-url origin "${CI_REPOSITORY_URL}"19Checking cache for 0_go_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected...20Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/0_go_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected ETag="76cdb2bad9582d23c1f6f4d868218d6c"21Successfully extracted cache22Checking cache for 1_package_package-lock-8f7613bddac4d195f7467703598a02b053ef8a5f-non_protected...23Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/1_package_package-lock-8f7613bddac4d195f7467703598a02b053ef8a5f-non_protected ETag="b4634ef942f49e1cfcb02b783d90d79c"24Successfully extracted cache25Checking cache for 2_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected...26Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/2_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected ETag="ecdbaeff7dffae6fb5660148edb642ca"27Successfully extracted cache29Using docker image sha256:a284feacf6f452a0551b78dbc7bbdfc1e40204047668d8a7042f67a04536533f for ruby:3.3 with digest ruby@sha256:2fd25434f88fd15628fec640bec8e40201128aadd00157e7a3f88a25567ba713 ...30$ [[ -f "Gemfile" ]] || (bundle init && bundle add gitlab-dangerfiles --version "")31Writing new Gemfile to /builds/gitlab-com/content-sites/handbook/Gemfile32Fetching gem metadata from https://rubygems.org/..............33Resolving dependencies...34Fetching gem metadata from https://rubygems.org/...........35Fetching rake 13.2.136Installing rake 13.2.137Fetching public_suffix 6.0.138Fetching base64 0.2.039Fetching bigdecimal 3.1.940Fetching claide 1.1.041Installing public_suffix 6.0.142Fetching colored2 3.1.243Installing base64 0.2.044Fetching nap 1.1.045Installing bigdecimal 3.1.9 with native extensions46Installing claide 1.1.047Installing colored2 3.1.248Fetching open4 1.3.449Fetching csv 3.3.250Installing nap 1.1.051Installing open4 1.3.452Fetching uri 1.0.253Fetching json 2.10.154Installing csv 3.3.255Installing uri 1.0.256Fetching logger 1.6.657Fetching rchardet 1.9.058Installing json 2.10.1 with native extensions59Installing logger 1.6.660Fetching rexml 3.4.161Installing rchardet 1.9.062Installing rexml 3.4.163Fetching pstore 0.1.464Fetching unicode-display_width 2.6.065Installing pstore 0.1.466Fetching mini_mime 1.1.567Installing unicode-display_width 2.6.068Fetching addressable 2.8.769Installing mini_mime 1.1.570Fetching cork 0.3.071Installing addressable 2.8.772Installing cork 0.3.073Fetching net-http 0.6.074Fetching kramdown 2.5.175Installing net-http 0.6.076Fetching terminal-table 3.0.277Installing kramdown 2.5.178Installing terminal-table 3.0.279Fetching claide-plugins 0.9.280Installing claide-plugins 0.9.281Fetching git 1.19.182Installing git 1.19.183Fetching faraday-net_http 3.4.084Installing faraday-net_http 3.4.085Fetching kramdown-parser-gfm 1.1.086Installing kramdown-parser-gfm 1.1.087Fetching faraday 2.12.288Installing faraday 2.12.289Fetching faraday-http-cache 2.5.190Fetching sawyer 0.9.291Installing faraday-http-cache 2.5.192Installing sawyer 0.9.293Fetching octokit 9.2.094Installing octokit 9.2.095Fetching danger 9.5.196Installing danger 9.5.197Fetching multi_xml 0.7.198Installing multi_xml 0.7.199Fetching httparty 0.22.0100Installing httparty 0.22.0101Fetching gitlab 5.1.0102Installing gitlab 5.1.0103Fetching danger-gitlab 9.0.0104Installing danger-gitlab 9.0.0105Fetching gitlab-dangerfiles 4.8.1106Installing gitlab-dangerfiles 4.8.1107$ [[ ! -f "Gemfile.lock" ]] || bundle config set --local frozen "true"108$ bundle install109Bundle complete! 1 Gemfile dependency, 37 gems now installed.110Use `bundle info [gemname]` to see where a bundled gem is installed.111$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command112$ if [ -z "${GITLAB_API_TOKEN}" ]; then # collapsed multi-line command113To use retry middleware with Faraday v2.0+, install `faraday-retry` gem114Importing rule architecture at /builds/gitlab-com/content-sites/handbook/danger/architecture115Importing rule z_retry_link at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.1/lib/danger/rules/z_retry_link116Results:117Messages:118- [ ] This merge request might require a review from a [Coach Engineer](https://handbook.gitlab.com/handbook/engineering/architecture/workflow/).119Markdown:120## Architecture Evolution Review121This merge request might require a review from a [Coach Engineer](https://handbook.gitlab.com/handbook/engineering/architecture/workflow/).122The following files, which might require the additional review, have been changed:123* `content/handbook/engineering/architecture/design-documents/ci_pipelines_for_github/_index.md`124**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-com/content-sites/handbook/-/jobs/9187130986) that generated this comment.**126Creating cache 0_go_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected...127WARNING: /builds/gitlab-com/content-sites/handbook/.GOPATH/pkg/mod/: no matching files. Ensure that the artifact path is relative to the working directory (/builds/gitlab-com/content-sites/handbook) 128Archive is up to date! 129Created cache130Creating cache 1_package_package-lock-8f7613bddac4d195f7467703598a02b053ef8a5f-non_protected...131/builds/gitlab-com/content-sites/handbook/.npm: found 710 matching artifact files and directories 132Archive is up to date! 133Created cache134Creating cache 2_go-b536555094b8e66d471b79a6931b609e110eaab5-non_protected...135/builds/gitlab-com/content-sites/handbook/.hugo_cache: found 11371 matching artifact files and directories 136Archive is up to date! 137Created cache139Job succeeded