danger-review
Passed Started
by
@furkanayhan
Furkan Ayhan
1Running with gitlab-runner 17.4.0~pre.110.g27400594 (27400594)2 on green-4.saas-linux-medium-amd64.runners-manager.gitlab.com/default Yy-Tzs3Q, system ID: s_57a32fe7e1c13 feature flags: FF_USE_FASTZIP:true4Resolving secrets6Using Docker executor with image ruby:3.3 ...7Pulling docker image ruby:3.3 ...8Using docker image sha256:1d69971d723a5c3f59f9934d52ad6499f535a7562b464fbf014037e7d856464b for ruby:3.3 with digest ruby@sha256:9ee601015fbb7c610ae02137d5698ab712f821069eaf7c0548e58a5b609970aa ...10Running on runner-yy-tzs3q-project-42817607-concurrent-0 via runner-yy-tzs3q-s-l-m-amd64-1726169070-ed33bea8...12Fetching changes...13Initialized empty Git repository in /builds/gitlab-com/content-sites/handbook/.git/14Created fresh repository.15Checking out 30168de6 as detached HEAD (ref is refs/merge-requests/8537/train)...16Skipping Git submodules setup17$ git remote set-url origin "${CI_REPOSITORY_URL}"19Checking cache for 0_go_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected...20Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/0_go_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected ETag="76cdb2bad9582d23c1f6f4d868218d6c"21Successfully extracted cache22Checking cache for 1_package_package-lock-58c2bb69bb433e482495a7d52da0334b052bf3de-non_protected...23Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/1_package_package-lock-58c2bb69bb433e482495a7d52da0334b052bf3de-non_protected ETag="e5736da4848552b799f18881a7879e5e"24Successfully extracted cache25Checking cache for 2_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected...26Downloading cache from https://storage.googleapis.com/gitlab-com-runners-cache/project/42817607/2_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected ETag="9bb65eb896caa4298342f8e339a63742"27Successfully extracted cache29Using docker image sha256:1d69971d723a5c3f59f9934d52ad6499f535a7562b464fbf014037e7d856464b for ruby:3.3 with digest ruby@sha256:9ee601015fbb7c610ae02137d5698ab712f821069eaf7c0548e58a5b609970aa ...30$ [[ -f "Gemfile" ]] || (bundle init && bundle add gitlab-dangerfiles --version "")31Writing new Gemfile to /builds/gitlab-com/content-sites/handbook/Gemfile32Fetching gem metadata from https://rubygems.org/..............33Resolving dependencies...34Fetching gem metadata from https://rubygems.org/...........35Fetching rake 13.2.136Installing rake 13.2.137Fetching public_suffix 6.0.138Fetching bigdecimal 3.1.839Fetching claide 1.1.040Fetching colored2 3.1.241Installing public_suffix 6.0.142Fetching nap 1.1.043Installing bigdecimal 3.1.8 with native extensions44Installing claide 1.1.045Installing colored2 3.1.246Fetching open4 1.3.447Fetching csv 3.3.048Installing nap 1.1.049Installing open4 1.3.450Fetching uri 0.13.151Fetching logger 1.6.152Installing csv 3.3.053Installing uri 0.13.154Fetching rchardet 1.8.055Installing logger 1.6.156Fetching rexml 3.3.757Fetching unicode-display_width 2.5.058Installing rchardet 1.8.059Fetching mini_mime 1.1.560Installing rexml 3.3.761Installing unicode-display_width 2.5.062Fetching addressable 2.8.763Installing mini_mime 1.1.564Fetching cork 0.3.065Installing addressable 2.8.766Fetching net-http 0.4.167Installing cork 0.3.068Installing net-http 0.4.169Fetching terminal-table 3.0.270Fetching kramdown 2.4.071Fetching claide-plugins 0.9.272Installing terminal-table 3.0.273Fetching git 1.19.174Installing kramdown 2.4.075Installing claide-plugins 0.9.276Installing git 1.19.177Fetching faraday-net_http 3.3.078Installing faraday-net_http 3.3.079Fetching faraday 2.11.080Installing faraday 2.11.081Fetching faraday-http-cache 2.5.182Fetching sawyer 0.9.283Installing faraday-http-cache 2.5.184Installing sawyer 0.9.285Fetching octokit 9.1.086Installing octokit 9.1.087Fetching kramdown-parser-gfm 1.1.088Installing kramdown-parser-gfm 1.1.089Fetching danger 9.5.090Installing danger 9.5.091Fetching multi_xml 0.7.192Installing multi_xml 0.7.193Fetching httparty 0.22.094Installing httparty 0.22.095Fetching gitlab 5.0.096Installing gitlab 5.0.097Fetching danger-gitlab 9.0.098Installing danger-gitlab 9.0.099Fetching gitlab-dangerfiles 4.8.0100Installing gitlab-dangerfiles 4.8.0101$ [[ ! -f "Gemfile.lock" ]] || bundle config set --local frozen "true"102$ bundle install103Bundle complete! 1 Gemfile dependency, 34 gems now installed.104Use `bundle info [gemname]` to see where a bundled gem is installed.105$ if [[ "$CI_MERGE_REQUEST_PROJECT_URL" != "$CI_MERGE_REQUEST_SOURCE_PROJECT_URL" || -z "${GITLAB_API_TOKEN}" ]]; then # collapsed multi-line command106$ if [ -z "${GITLAB_API_TOKEN}" ]; then # collapsed multi-line command107/usr/local/lib/ruby/3.3.0/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.108You can add ostruct to your Gemfile or gemspec to silence this warning.109To use retry middleware with Faraday v2.0+, install `faraday-retry` gem110To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses111/usr/local/bundle/gems/danger-9.5.0/lib/danger/commands/local.rb:1: warning: pstore was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.112You can add pstore to your Gemfile or gemspec to silence this warning.113/usr/local/bundle/gems/danger-9.5.0/lib/danger/request_sources/vsts.rb:2: warning: base64 was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.114You can add base64 to your Gemfile or gemspec to silence this warning.115Importing rule architecture at /builds/gitlab-com/content-sites/handbook/danger/architecture116Importing rule z_retry_link at /usr/local/bundle/gems/gitlab-dangerfiles-4.8.0/lib/danger/rules/z_retry_link117Results:118Messages:119- [ ] This merge request might require a review from a [Coach Engineer](https://handbook.gitlab.com/handbook/engineering/architecture/workflow/).120Markdown:121## Architecture Evolution Review122This merge request might require a review from a [Coach Engineer](https://handbook.gitlab.com/handbook/engineering/architecture/workflow/).123The following files, which might require the additional review, have been changed:124* `content/handbook/engineering/architecture/design-documents/ci_pipeline_processing/_index.md`125**If needed, you can retry the [🔁 `danger-review` job](https://gitlab.com/gitlab-com/content-sites/handbook/-/jobs/7813365730) that generated this comment.**127Creating cache 0_go_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected...128WARNING: /builds/gitlab-com/content-sites/handbook/.GOPATH/pkg/mod/: no matching files. Ensure that the artifact path is relative to the working directory (/builds/gitlab-com/content-sites/handbook) 129Archive is up to date! 130Created cache131Creating cache 1_package_package-lock-58c2bb69bb433e482495a7d52da0334b052bf3de-non_protected...132/builds/gitlab-com/content-sites/handbook/.npm: found 902 matching artifact files and directories 133Archive is up to date! 134Created cache135Creating cache 2_go-9c2d8c7e99a9335b40f5fb0455a1203d2ec103c9-non_protected...136/builds/gitlab-com/content-sites/handbook/.hugo_cache: found 11368 matching artifact files and directories 137Archive is up to date! 138Created cache140Job succeeded