Turning on feature flag for % of actors + group
What are we trying to solve?
Clarify behavior when % actor rollout us used in conjunction with turning on a feature flag for a group/namespace.
More details
Scenario: you run these 2 commands:
/chatops run feature set --project=gitlab-org/gitlab some_feature true
/chatops run feature set some_feature 25
This MR from Jan 16, 2020 states:
Then `some_feature` will be enabled for 25% of the users interacting with`gitlab-org/gitlab`, and no one else.
But this MR, from May 15, 2020 states:
Then `some_feature` will be enabled for both 25% of actors and always when interacting with `gitlab-org/gitlab`.
What is confusing about this change in the docs is that it isn't clear that this logic actually changed when we introduced the % actors rollout. The chatops output (makes it seem like the former. Example output when I've run:
/chatops run feature set customizable_roles_per_user 50 --actors --staging
/chatops run feature set --group=staging-custom-roles-root-group customizable_roles_per_user true --staging
Which is it? Latter is what is on master