Follow-up from "Add Rollback command with `check` subcommand"
@rspeicher I decided not to block !180 (merged) with minor remarks.
I've applied one suggestion myself and opened this follow-up to discuss a couple of improvements/comments.
The following discussions from !180 (merged) should be addressed:
-
@nolith started a discussion: It seems that we do not support ordering by
finished_at:( -
@nolith started a discussion: I will suggest filtering by
status, we mentioned quite a few times to start triggering the start of a deployment. It think will be safer here to be specific about what we are looking for.sort: 'desc', status: 'success',WDYT?
-
@nolith started a discussion: What do you think about mentioning the timeout if it happened?
I'm wondering if in case of a timeout we may end up with something like "potentially unsafe to roll back (0 migrations, 0 post-deploy migrations)"