Suggestions and Fixes discovered by implementing it within my gitlab enterprise
Hey, nice component!
We just added your component into our gitlab ci/cd for embedded testing (v1.7.0). During this I discovered some Issues:
Our Group Access tokens do not start with glpat-
I don't know if this is something related to the gitlab version (GitLab Enterprise Edition v17.11.3-ee) but i had to remove/edit the regex validation
Wrong URL for wget
The url for the wget command results into 404
diff --git a/Device-Cloud-Pool-Mgmt/README.md b/Device-Cloud-Pool-Mgmt/README.md
index 82eaffb..a17b139 100644
--- a/Device-Cloud-Pool-Mgmt/README.md
+++ b/Device-Cloud-Pool-Mgmt/README.md
@@ -131,7 +131,7 @@ You can still see the Device Cloud in action with a single device as it still ha
2. Run the provisioning script with the following command (replace placeholders with your values). This is the command line you have been building in the text editor:
```bash
-wget https://gitlab.com/gitlab-accelerates-embedded/comp/device-cloud/device-cloud/-/raw/main/Device-Cloud-Pool-Mgmt/PROVISIONDEVICEGWRUNNER.sh?ref_type=heads -O /tmp/PROVISIONDEVICEGWRUNNER.sh ; sudo bash /tmp/PROVISIONDEVICEGWRUNNER.sh --runnergroupurl=https://gitlab.com/mygroup/embedded-runners --runnergroupaccesstoken=glpat-XXXXXXXXXXXXXXXXXXXX --devicepooldataprojectpath=some/group/path/embedded/deviceclouds/rpipicow --devicepooldataprojectaccesstoken=glpat-YYYYYYYYYYYYYYYYYYYY
+wget https://gitlab.com/gitlab-accelerates-embedded/comp/device-cloud/-/raw/main/Device-Cloud-Pool-Mgmt/PROVISIONDEVICEGWRUNNER.sh?ref_type=heads&inline=false -O /tmp/PROVISIONDEVICEGWRUNNER.sh ; sudo bash /tmp/PROVISIONDEVICEGWRUNNER.sh --runnergroupurl=https://gitlab.com/mygroup/embedded-runners --runnergroupaccesstoken=glpat-XXXXXXXXXXXXXXXXXXXX --devicepooldataprojectpath=some/group/path/embedded/deviceclouds/rpipicow --devicepooldataprojectaccesstoken=glpat-YYYYYYYYYYYYYYYYYYYY
```
3. The script will install GitLab Runner, register it with your GitLab instance, and provision the runner into the Device Cloud by creating a CI/CD variable.Two README's are not synced
DEVICE_POOL_PROJECT_ID is missing in the Step 5: Provision Runner Gateways examples. The examples in the "root" README.md helped me out. I would suggest to remove one of the two examples and only provide one "quick start" code example. This reduces the risk of some out of date examples.
Default DOCKEREXECUTORARGS values
In my case i had to remove all the --docker-devices and --docker-device-cgroup-rules from the PROVISIONDEVICEGWRUNNER.sh script. Because we just need a /dev/ttyUSB0 connection. So it would be great to make these settings variable or just add them to the readme for users with a raspberry pi setup.
"Uninstall" option
Due to my implementation and testing i registered a lot of runners... A LOT. It would be coole to get an option like "--prune" to get rid of all Runners and Variables for one Device Pool.
If you want, i can create a extra issue for each item in the list for better tracking.