Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
O
OSMyBiz
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35
    • Issues 35
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 2
    • Merge Requests 2
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • geometalab
  • OSMyBiz
  • Issues
  • #240

Closed
Open
Opened Nov 14, 2019 by Raphael Das Gupta@das-gOwner3 of 3 tasks completed3/3 tasks

Investigate how opening_url is different

In createDetailTags(...), it seems to suffice for most properties of businessPOI.details to check whether they're empty (have zero length). Apparently they contain empty strings when the corresponding form field has been left empty. For the businessPOI.details.opening_hours this isn't the case: It'll be undefined when the "Opening hours URL" form field is empty upon submit. (This was part of the cause of #239 (closed).)

  • Investigate how / why businessPOI.details.opening_hours is different from other businessPOI.details properties
  • Decide whether it should remain different
  • If not, change the implementation accordingly
Edited Mar 23, 2020 by Christopher
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: geometalab/osmybiz#240