The cargo-clippy tests trigger envision rebuild
Debugging Information
4/5 envision:cargo-clippy FAIL 48.70s exit status 101
>>> MESON_TEST_ITERATION=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 RUSTFLAGS=-Dwarnings MALLOC_PERTURB_=122 /usr/bin/cargo clippy --all-targets --all-features
――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
Listing only the last 100 lines from a long log.
--> src/ui/wivrn_conf_editor.rs:134:30
|
134 | add: bitrate_row = &number_entry_row(
| ^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `networkgrp` is never read
--> src/ui/wivrn_conf_editor.rs:144:26
|
144 | add: networkgrp = &adw::PreferencesGroup {
| ^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `encodersrgp` is never read
--> src/ui/wivrn_conf_editor.rs:160:26
|
160 | add: encodersrgp = &adw::PreferencesGroup {
| ^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `presets_btn` is never read
--> src/ui/wivrn_conf_editor.rs:164:41
|
164 | ... add_suffix: presets_btn = >k::Button {
| ^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `add_encoder_btn` is never read
--> src/ui/wivrn_conf_editor.rs:171:41
|
171 | ... add_suffix: add_encoder_btn = >k::Button {
| ^^^^^^^^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `win` is never read
--> src/ui/wivrn_encoder_presets_win.rs:37:16
|
37 | #[name(win)]
| ^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `tbview` is never read
--> src/ui/wivrn_encoder_presets_win.rs:42:24
|
42 | set_child: tbview = &adw::ToolbarView {
| ^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `top_bar` is never read
--> src/ui/wivrn_encoder_presets_win.rs:46:30
|
46 | add_top_bar: top_bar = &adw::HeaderBar {
| ^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `prefpage` is never read
--> src/ui/wivrn_encoder_presets_win.rs:50:30
|
50 | set_content: prefpage = &adw::PreferencesPage {
| ^^^^^^^^
|
= help: maybe it is overwritten before being read?
error: value assigned to `prefgrp` is never read
--> src/ui/wivrn_encoder_presets_win.rs:52:26
|
52 | add: prefgrp = &adw::PreferencesGroup {}
| ^^^^^^^
|
= help: maybe it is overwritten before being read?
error: this creates an owned instance just for comparison
--> src/file_builders/active_runtime_json.rs:123:19
|
123 | if pfx == PathBuf::from(SYSTEM_PREFIX) {
| -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| help: try: `pfx == SYSTEM_PREFIX`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#cmp_owned
= note: `-D clippy::cmp-owned` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::cmp_owned)]`
error: could not compile `envision` (bin "envision") due to 94 previous errors
Caused by:
process didn't exit successfully: `/usr/bin/clippy-driver /usr/bin/rustc --crate-name envision --edition=2021 src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values())' -C metadata=ee26980b45b0f46d -C extra-filename=-0a68c3b08a7e2c4f --out-dir /builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps -C incremental=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/incremental -L dependency=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps --extern anyhow=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libanyhow-7705ac1b62af83c9.rmeta --extern ash=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libash-aa3673195626babf.rmeta --extern delicious_adwaita=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libdelicious_adwaita-3166ffcd2c3144a6.rmeta --extern gettextrs=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libgettextrs-e770cbfa16f10277.rmeta --extern git2=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libgit2-a6055c285ad18ea1.rmeta --extern gtk=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libgtk4-d31f5b12c835ae7b.rmeta --extern keyvalues_serde=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libkeyvalues_serde-f861a12614f9aac2.rmeta --extern lazy_static=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/liblazy_static-a70003eedaea3491.rmeta --extern adw=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/liblibadwaita-f23265bcfd2fc937.rmeta --extern libmonado=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/liblibmonado-855decf143252019.rmeta --extern nix=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libnix-615e8aaeb282cad5.rmeta --extern notify_rust=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libnotify_rust-0ee0b0be0509a1d8.rmeta --extern openxr=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libopenxr-0109b73b4a82b718.rmeta --extern relm4=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/librelm4-957918d9c93e643f.rmeta --extern relm4_components=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/librelm4_components-317be9f68d2fd3e5.rmeta --extern reqwest=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libreqwest-00049ff033665105.rmeta --extern rusb=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/librusb-4c47cde4038b5643.rmeta --extern serde=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libserde-a14f637d0f958fe0.rmeta --extern serde_json=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libserde_json-dc89441e8e9a4cd2.rmeta --extern serde_yaml=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libserde_yaml-5d6378004c8890f9.rmeta --extern sha2=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libsha2-62efadbfda56b919.rmeta --extern tokio=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libtokio-20d9ae59a5c19a2b.rmeta --extern tracing=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libtracing-a3e577bd373aeb0c.rmeta --extern tracing_appender=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libtracing_appender-c9ee15c148867c61.rmeta --extern tracing_subscriber=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libtracing_subscriber-a2cf85d23728180c.rmeta --extern tracker=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libtracker-8ada7f82b2661af7.rmeta --extern uuid=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libuuid-d29f1c009c6f524d.rmeta --extern vte4=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libvte4-4615c7622f32cede.rmeta --extern xdg=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libxdg-9c854ec3fc3bdfda.rmeta --extern zbus=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/deps/libzbus-091ac07886547959.rmeta -Dwarnings -L native=/builddir/build/BUILD/envision-3.2.0-build/envision-3.2.0/target/debug/build/libgit2-sys-ef705a66f2b360c4/out/build -L native=/usr/lib64` (exit status: 1)
warning: build failed, waiting for other jobs to finish...
error: could not compile `envision` (bin "envision" test) due to 94 previous errorsWhen running "meson test", a rebuild of the envision application is triggered. For some reason the build is done with warnings treated as errors and fails the test.
I have a patch to suggest for this issue that will avoid to trigger the envision application rebuild.