facebook component not included in new versions anymore - Job Failed #429021877
Job #429021877 failed for d4393126:
We should just remove the facebook
from the generator and update the unity_versions.old.yml
to include it for all versions that used to support it.
https://gitlab.com/gableroux/unity3d/-/merge_requests/82#note_285680049
To complete this issue, here's what needs to be done:
-
Remove facebook from here:
https://gitlab.com/gableroux/unity3d/-/blob/5bdeca28/ci-generator/src/gitlab_ci_generator.py#L90 -
Fix the tests accordingly and update snapshots (refer to documentation to see how) -
Look at all recently failed pipelines on the master branch and list identify which version doesn't include facebook
component anymore:
master branch: https://gitlab.com/gableroux/unity3d/-/jobs/432168799 https://gitlab.com/gableroux/unity3d/-/jobs/432189343 https://gitlab.com/gableroux/unity3d/-/jobs/429021877 https://gitlab.com/gableroux/unity3d/-/jobs/422968480
recent branch (just got merged, but same problem): https://gitlab.com/gableroux/unity3d/-/jobs/441574347 https://gitlab.com/gableroux/unity3d/-/jobs/441574860
known affected versions:
- 2020.1.0a21
- 2020.1.0a22
- 2020.1.0a23
- 2019.3.0f6
- 2019.3.1f1
So that means all versions that are above these don't come with Facebook anymore (or component name changed, that's possible, I did not verify that)
Once the fix is done, if one wants to build an older image and have the facebook component, that person will need to add platforms
a bit like in here to the unity version definition to be able to build a facebook component image again:
platforms:
facebook:
components: Facebook-Games