External Tools fail to execute when the external tool is an .app application (low priority)

Original Reporter info from Mantis: Hansaplast

• Reporter name: Hans Luijten

Description:

When adding an external tool, the tool does not get executed when the said tool is an .app.

Most likely what happens is that "someapplication.app" is being called, instead of "open someapplication.app". So the call fails.
I tried digging into the IDE code, but this went a little over my head.

To illustrate this in Terminal:

$ /Applications/BBEdit.app
-bash: /Applications/BBEdit.app: is a directory (fail)

$ open /Applications/BBEdit.app
(success - the .app starts)

Steps to reproduce:

On macOS, go to the menu "Tools" - "Configure external tools" - "Add".
Enter some title, and select an .app application (for example BBEdit, Calculator, or any app for that matter).
Click "OK" and click "OK" again to get out of the external tool editor.

Now go back to the "Tools" menu and select the newly added tool.
Nothing happens.

When running Lazarus from Terminal, clicking the newly added tool will show:
Error: (lazarus) [TExternalTools.RunToolAndDetach] BBEdit failed: executable is a directory: "/Applications/BBEdit.app"

(I have tested this with several .app's - they all come back with the same result)

Additional information:

Lazarus 2.1.0 r62054M FPC 3.0.4 x86_64-darwin-cocoa (beta)

Mantis conversion info:

• Mantis ID: 36314
• OS: macOS
• OS Build: 10.14.x
• Build: r62054M
• Platform: Cocoa
• Version: 2.0.7 (SVN)
• Fixed in revision: r62254 (#18fe49e2)
• Monitored by: » Hansaplast (Hans Luijten)