Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Lazarus Lazarus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,095
    • Issues 2,095
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • FPC
  • Lazarus
  • LazarusLazarus
  • Issues
  • #21732
Closed
Open
Created Apr 13, 2012 by FPC Admin account@fpc_adminOwner

TCarbonSpinEdit.CreateWidget has possible bad loop

Original Reporter info from Mantis: djenkins @dfjenkins
  • Reporter name: David Jenkins

Description:

Calling GetEditBounds results in a call to GetPreferredSize that can rely on Widget already being created. So the call in TCarbonSpinEdit.CreateWidget to CreateEditUniCodeTextControl with GetEditBounds() as a param creates a bad loop.

Suggested fix is to drop GetEditBounds call and instead call SetBounds(ParamsToRect(AParams)) at the bottom of the function.

Patch against 36681 attached.

Mantis conversion info:

  • Mantis ID: 21732
  • Version: 0.9.30.5 (SVN)
  • Fixed in revision: 36962 (#322f9edf)
  • Monitored by: » @dfjenkins (David Jenkins)
Assignee
Assign to
Time tracking