Typos of extra semicolon after "then" in some packages

Similar to lazarus!403 (closed), I checked packages from OPM for then; typos and found several cases. I've already created pull requests in some repos.

LGenerics

A pull request has been submitted to the repository.

Click to view the patch

diff --git a/LGenerics/test/testset/lgjsontest.pas b/LGenerics/test/testset/lgjsontest.pas
index de754e59..6b9826d3 100644
--- a/LGenerics/test/testset/lgjsontest.pas
+++ b/LGenerics/test/testset/lgjsontest.pas
@@ -210,10 +210,10 @@ begin
   if Dir = '' then exit;
   TestDir := Dir + DirectorySeparator + 'json_testset' + DirectorySeparator;
   Dir := TestDir + ParseDir + DirectorySeparator;
-  if DirectoryExists(Dir) then;
+  if DirectoryExists(Dir) then
     TestFileList := FindAllFiles(Dir);
   Dir := TestDir + PatchDir + DirectorySeparator;
-  if DirectoryExists(Dir) then;
+  if DirectoryExists(Dir) then
     TestPatchList := FindAllFiles(Dir);
 end;

ZeosDBO

A pull request has been submitted to the repository.

Click to view the patch

diff --git a/zeosdbo/packages/lazarus/ztestall.lpr b/zeosdbo/packages/lazarus/ztestall.lpr
index 4f95ad98..0de6cf13 100644
--- a/zeosdbo/packages/lazarus/ztestall.lpr
+++ b/zeosdbo/packages/lazarus/ztestall.lpr
@@ -191,7 +191,7 @@ end;
 
 procedure TMyTestRunner.DoTestRun(ATest: TTest);
 begin
-  if CommandLineSwitches.suitename <> '' then ;
+  if CommandLineSwitches.suitename <> '' then
     if ATest.TestName = 'SuiteList' then
       (ATest as TTestSuite).TestName := CommandLineSwitches.suitename;
   inherited DoTestRun(ATest);
diff --git a/zeosdbo/src/webservice/server/dbcproxysecuritymodule.pas b/zeosdbo/src/webservice/server/dbcproxysecuritymodule.pas
index 41ee7a72..62e07eca 100644
--- a/zeosdbo/src/webservice/server/dbcproxysecuritymodule.pas
+++ b/zeosdbo/src/webservice/server/dbcproxysecuritymodule.pas
@@ -487,7 +487,7 @@ var
   x: Integer;
 begin
   for x := 0 to Length(FModuleChain) - 1 do
-    if Assigned(FModuleChain[x]) then;
+    if Assigned(FModuleChain[x]) then
       FreeAndNil(FModuleChain[x]);
   inherited;
 end;
@@ -549,7 +549,7 @@ var
   x: Integer;
 begin
   for x := 0 to Length(FModuleChain) - 1 do
-    if Assigned(FModuleChain[x]) then;
+    if Assigned(FModuleChain[x]) then
       FreeAndNil(FModuleChain[x]);
   inherited;
 end;

LAMW

A pull request has been submitted to the repository.

Click to view the patch

diff --git a/LAMW/android_bridges/csignaturepad.pas b/LAMW/android_bridges/csignaturepad.pas
index 097ac7d4..55a4f248 100644
--- a/LAMW/android_bridges/csignaturepad.pas
+++ b/LAMW/android_bridges/csignaturepad.pas
@@ -214,7 +214,7 @@ begin
   if FPenColor <> colbrBlack then
      jcSignaturePad_SetPenColor(gApp.jni.jEnv, FjObject, GetARGB(FCustomColor, FPenColor));
 
-  if FMinPenStrokeWidth <> 3 then;
+  if FMinPenStrokeWidth <> 3 then
     jcSignaturePad_SetMinPenStrokeWidth(gApp.jni.jEnv, FjObject, FMinPenStrokeWidth);
 
   if FMaxPenStrokeWidth <> 7 then
diff --git a/LAMW/demos/GUI/AppSMSDemo1/jni/unit1.pas b/LAMW/demos/GUI/AppSMSDemo1/jni/unit1.pas
index a4526130..ffd4a18a 100644
--- a/LAMW/demos/GUI/AppSMSDemo1/jni/unit1.pas
+++ b/LAMW/demos/GUI/AppSMSDemo1/jni/unit1.pas
@@ -129,7 +129,7 @@ begin
         auxList.Delimiter:= '#';
         auxList.StrictDelimiter:= True;
         auxList.DelimitedText:= smsReceived;
-        if auxList.Count > 1 then;
+        if auxList.Count > 1 then
         begin
           smsCaller:= auxList.Strings[0];
           smsBody:=  auxList.Strings[1];
diff --git a/LAMW/ide_tools/androidprojoptions.pas b/LAMW/ide_tools/androidprojoptions.pas
index 5b5fdea1..df5ad60b 100644
--- a/LAMW/ide_tools/androidprojoptions.pas
+++ b/LAMW/ide_tools/androidprojoptions.pas
@@ -1229,7 +1229,7 @@ var
   list: TStringList;
 begin
   newTheme:= cbTheme.Text;
-  if newTheme <> FDefaultTheme then;
+  if newTheme <> FDefaultTheme then
   begin
      list:= TStringList.Create;

EyeCandyControls

User Blaazen (@Blaazen) has been sent a private message.

Click to view the patch

diff --git a/EC_Controls/EC_Controls/ecscheme.pas b/EC_Controls/EC_Controls/ecscheme.pas
index b60084d6..42531150 100644
--- a/EC_Controls/EC_Controls/ecscheme.pas
+++ b/EC_Controls/EC_Controls/ecscheme.pas
@@ -562,7 +562,7 @@ end;
 function TECDevice.ClearOutputs: Integer;
 begin
   Result:=length(Outputs);
-  if Result>0 then;
+  if Result>0 then
     begin
       SetLength(FOutputs, 0);
       UpdateScheme;

WST

A private message was sent to user inoussa, although there has been no activity for a long time. Maybe someone else in this list received a patch?

Click to view the patch

diff --git a/wst/ws_helper/ws_parser_imp.pas b/wst/ws_helper/ws_parser_imp.pas
index f8c17cfc..13b168c4 100644
--- a/wst/ws_helper/ws_parser_imp.pas
+++ b/wst/ws_helper/ws_parser_imp.pas
@@ -1893,7 +1893,7 @@ begin
       raise EXsdParserException.CreateFmt(SERR_ExpectedTypeDefinition,[FTypeName]);
     locContinue := locSym.InheritsFrom(TPasUnresolvedTypeRef) or
                    ( IsEmbeddedType(TPasType(locSym)) <> FEmbededDef );
-    if not locContinue then;
+    if not locContinue then
       Result := locSym as TPasType;
   end;
   if locContinue then begin

Jvcllaz

I couldn't find any information about the repository or maintainer. The original repository listed in the wiki does not have the file with the error at all.

Click to view the patch

diff --git a/jvcllaz/examples/JvDBTreeView/main.pas b/jvcllaz/examples/JvDBTreeView/main.pas
index 17361692..af7f1f4a 100644
--- a/jvcllaz/examples/JvDBTreeView/main.pas
+++ b/jvcllaz/examples/JvDBTreeView/main.pas
@@ -192,7 +192,7 @@ begin
   BufDataset1.Filename := Application.Location + 'JvDBGridDemoData.dat';

   if not FileExists(BufDataset1.FileName) then begin
-    if BufDataset1.FieldDefs.IndexOf('ID') = -1 then;
+    if BufDataset1.FieldDefs.IndexOf('ID') = -1 then
       BufDataset1.FieldDefs.Add('ID', ftInteger);
     if BufDataset1.FieldDefs.IndexOf('ParentID') = -1 then
       BufDataset1.FieldDefs.Add('ParentID', ftInteger);