Incorrect fillchar call
I have found 4 instances where fillchar is called with incorrect parameters:
compiler\fmodule.pas (338,9) Fillchar(current_filepos,0,sizeof(current_filepos));
packages\rtl-console\src\win\video.pp (778,3) FillChar (VioMode, 0, SizeOf (VioMode));
packages\winceunits\src\windbase.pp (534,3) fillchar(pguid,0,sizeof(CEGUID));
rtl\os2\systhrd.inc (253,2) FillChar (DataIndex^^, 0, ThreadVarBlockSize);
These may not be causing any direct harm but they could cause random problems that will be hard to diagnose so they should be fixed.
Edited by Michael Van Canneyt