Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • FPC Source FPC Source
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,274
    • Issues 1,274
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 59
    • Merge requests 59
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FPC
  • FPC
  • FPC SourceFPC Source
  • Issues
  • #37579
Closed
Open
Created Aug 15, 2020 by FPC Admin account@fpc_adminOwner

Source code contains German words as identifiers

Original Reporter info from Mantis: kays @KaiBurghardt
  • Reporter name: Kai Burghardt

Description:

The compiler source code contains some German language artifacts. I am aware of the compiler’s history, so it’s OK. Nevertheless, all identifiers should stick to one natural language, that means English in this case.

Steps to reproduce:

First, ensure there are no identifiers already bearing the new names, so e.g.

egrep -Ri '(atsign|[lr](parenthesis|sqbracket))' ./*

Then, perform the actual substitution:

	for file in `find -name '*.pas'`; do
		for pattern in `cat << EOT
	s/_LKLAMMER/_LPARENTHESIS/g
	s/_RKLAMMER/_RPARENTHESIS/g
	s/_KLAMMERAFFE/_ATSIGN/g
	s/_LECKKLAMMER/_LSQBRACKET/g
	s/_RECKKLAMMER/_RSQBRACKET/g
	EOT
			`; do
			sed -i "${pattern}" ${file}
		done
	done

Lastly, check that we didn’t miss anything because of the uppercase letters:

egrep -Ri '(Klammeraffe|[LR](eck)?Klammer)' ./*

Additional information:

I refrain from submitting a patch, since it will become too bloated nobody will actually like to manually review that.

Mantis conversion info:

  • Mantis ID: 37579
  • OS: GNU/Linux
  • OS Build: 4.2.0
  • Build: 3.0.4+dfsg-11 [2017/12/30]
  • Platform: x86_64
  • Fixed in version: 3.3.1
  • Fixed in revision: 46475 (#075057f9)
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking